Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SttpRestClient request configuration #570

Merged
merged 4 commits into from
Apr 20, 2020
Merged

SttpRestClient request configuration #570

merged 4 commits into from
Apr 20, 2020

Conversation

mowczare
Copy link
Contributor

@mowczare mowczare commented Apr 17, 2020 •
edited

Currently, method toSttpRequest in SttpRestClient creates basicRequest.method with default RequestOptions which hardcodes both read- and requestTimeout HTTP request parameters to 60 seconds.
Exposed RequestOptions to the SttpRestClient constructor to enable request timeout configuration.

@mowczare mowczare requested a review from ghik April 17, 2020 09:46
@mowczare mowczare mentioned this pull request Apr 17, 2020
Closed
@mowczare
Copy link
Contributor Author

@ghik Will you be making second round? :)

@mowczare mowczare merged commit bf12e76 into 0.8.x Apr 20, 2020
@mowczare mowczare deleted the sttp-request-config-0.8 branch April 20, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghik ghik ghik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mowczare @ghik