Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View rendering improvements #584

Merged
merged 4 commits into from
May 11, 2020
Merged

View rendering improvements #584

merged 4 commits into from
May 11, 2020

Conversation

ddworak
Copy link
Member

@ddworak ddworak commented Apr 28, 2020

Stacked on #583

  • handle case where container views are swapped, e.g. Root -> View1 -> View2 => Root -> View2 -> View1, which would not render due to child container cycle
  • handle non-element nodes in child containers cleanup

@ddworak
Enable child rendering in tests
7555b8d
@ddworak
Handle container view swapping
bbf73b9 
Routing between Root -> ViewA -> ViewB and Root -> ViewB -> ViewA failed in the browser due to ViewA containing B child container.
@ddworak
Improve testing for non-element children templates
8c05553
@ddworak
Child view container should remove all nodes when clearing
5c5a04f
@ddworak ddworak requested a review from najder-k April 28, 2020 07:58
@ddworak ddworak merged commit af573b5 into view-renderer May 11, 2020
@ddworak ddworak deleted the view-renderer-swap branch May 11, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@najder-k najder-k najder-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddworak @najder-k