Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view renderer for nested views #701

Merged
merged 7 commits into from
Nov 26, 2020
Merged

Fix view renderer for nested views #701

merged 7 commits into from
Nov 26, 2020

Conversation

ddworak
Copy link
Member

@ddworak ddworak commented Nov 23, 2020

No description provided.

@ddworak ddworak added this to the 0.9.0 milestone Nov 23, 2020
bgrochal
bgrochal approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@bgrochal bgrochal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions left to be considered, but LGTM generally. I like the way it works now - clear and consistent, nicely done 👍

core/.js/src/main/scala/io/udash/view/ViewRenderer.scala Outdated Show resolved Hide resolved
core/.js/src/main/scala/io/udash/view/ViewRenderer.scala Show resolved Hide resolved
core/.js/src/main/scala/io/udash/view/ViewRenderer.scala Show resolved Hide resolved
core/.js/src/main/scala/io/udash/view/ViewRenderer.scala Outdated Show resolved Hide resolved
core/.js/src/main/scala/io/udash/view/ViewRenderer.scala Show resolved Hide resolved
core/.js/src/main/scala/io/udash/view/ViewRenderer.scala Show resolved Hide resolved
core/.js/src/test/scala/io/udash/testing/TestViewFactory.scala Show resolved Hide resolved
@ddworak ddworak merged commit 73ed196 into master Nov 26, 2020
@ddworak ddworak deleted the view-renderer-bug branch November 26, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrochal bgrochal bgrochal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddworak @bgrochal