Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] made a classifier based on information retrieved from QR on the omr sheets #116

Merged
merged 60 commits into from
Mar 8, 2023
Merged

[Feature] made a classifier based on information retrieved from QR on the omr sheets #116

merged 60 commits into from
Mar 8, 2023

Conversation

rudrapsc
Copy link
Contributor

@rudrapsc rudrapsc commented Jan 2, 2023 •
edited by Udayraj123
Loading

Fixes #105

@Udayraj123 Udayraj123 marked this pull request as draft January 2, 2023 18:43
@Udayraj123 Udayraj123 mentioned this pull request Jan 2, 2023
Open
Udayraj123
Udayraj123 reviewed Jan 16, 2023
View reviewed changes
src/processors/CropPage.py Show resolved Hide resolved
src/defaults/schema.json Outdated Show resolved Hide resolved
src/processors/ReadBarcode.py Show resolved Hide resolved
src/processors/ReadBarcode.py Outdated Show resolved Hide resolved
src/utils/TemplateByBarcode.py Outdated Show resolved Hide resolved
src/utils/TemplateByBarcode.py Outdated Show resolved Hide resolved
src/utils/TemplateByBarcode.py Outdated Show resolved Hide resolved
@Udayraj123 Udayraj123 changed the base branch from master to dev January 16, 2023 16:40
@Udayraj123 Udayraj123 marked this pull request as ready for review January 16, 2023 16:40
Udayraj123
Udayraj123 previously approved these changes Jan 16, 2023
View reviewed changes
Copy link
Owner

@Udayraj123 Udayraj123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rudrapsc
Copy link
Contributor Author

to check the program
follow the steps in Readme:-
then run python3 main.py -i ./samples/sample7

@Udayraj123 Udayraj123 changed the title made a classifier based on information retrieved from QR on the omr sheets [Feature] made a classifier based on information retrieved from QR on the omr sheets Jan 22, 2023
@Udayraj123
Copy link
Owner

@rudrapsc can you share the proposal link here as well? It'll help new folks to go through the process for new feature work

@Udayraj123
Copy link
Owner

Also for master merge, you'd need a more generic approach as discussed. On top of the evaluation PR (which contains a revamp). #118

@Udayraj123 Udayraj123 dismissed their stale review February 12, 2023 07:12

Stale code. Master code has moved ahead

@Udayraj123
Copy link
Owner

For master merge we will need to make the code compatible with #118 getting merged now

@rudrapsc
Copy link
Contributor Author

For master merge we will need to make the code compatible with #118 getting merged now

I am busy with some other work as of now, can I get back on this by 24th feb'23?

@Udayraj123
Copy link
Owner

Cool that is alright @rudrapsc. You can ping back by the month end.

@Udayraj123 Udayraj123 merged commit c4f83c9 into Udayraj123:dev Mar 8, 2023
@Udayraj123
Copy link
Owner

Thought of a more generalised version and will write a schema spec for it on the github issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Udayraj123 Udayraj123 Udayraj123 left review comments

Assignees
No one assigned
Labels
advanced enhancement New feature or request fossoverflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rudrapsc @Udayraj123