partial merge bitcoin#16465: lint: Add false positive to python dead …

…code linter

.travis/lint_04_install.sh

@@ -6,9 +6,9 @@
 
 export LC_ALL=C
 
-travis_retry pip install codespell==1.15.0
-travis_retry pip install flake8==3.5.0
-travis_retry pip install vulture==0.29
+travis_retry pip3 install codespell==1.15.0
+travis_retry pip3 install flake8==3.5.0
+travis_retry pip3 install vulture==0.29
 travis_retry pip3 install yq
 
 SHELLCHECK_VERSION=v0.6.0

test/lint/lint-python-dead-code-whitelist

@@ -0,0 +1,45 @@
+BadInputOutpointIndex  # unused class (test/functional/data/invalid_txs.py)
+_.carbon_path  # unused attribute (contrib/macdeploy/custom_dsstore.py)
+connection_lost  # unused function (test/functional/test_framework/mininode.py)
+connection_made  # unused function (test/functional/test_framework/mininode.py)
+_.converter  # unused attribute (test/functional/test_framework/test_framework.py)
+_.daemon  # unused attribute (test/functional/test_framework/socks5.py)
+data_received  # unused function (test/functional/test_framework/mininode.py)
+DuplicateInput  # unused class (test/functional/data/invalid_txs.py)
+_.filename  # unused attribute (contrib/macdeploy/custom_dsstore.py)
+InvalidOPIFConstruction  # unused class (test/functional/data/invalid_txs.py)
+_.is_compressed  # unused property (test/functional/test_framework/key.py)
+legacy  # unused variable (test/functional/test_framework/address.py)
+msg_generic  # unused class (test/functional/test_framework/messages.py)
+NonexistentInput  # unused class (test/functional/data/invalid_txs.py)
+on_addr  # unused function (test/functional/test_framework/mininode.py)
+on_blocktxn  # unused function (test/functional/test_framework/mininode.py)
+on_block  # unused function (test/functional/test_framework/mininode.py)
+on_cmpctblock  # unused function (test/functional/test_framework/mininode.py)
+on_feefilter  # unused function (test/functional/test_framework/mininode.py)
+on_getaddr  # unused function (test/functional/test_framework/mininode.py)
+on_getblocks  # unused function (test/functional/test_framework/mininode.py)
+on_getblocktxn  # unused function (test/functional/test_framework/mininode.py)
+on_getdata  # unused function (test/functional/test_framework/mininode.py)
+on_getheaders  # unused function (test/functional/test_framework/mininode.py)
+on_headers  # unused function (test/functional/test_framework/mininode.py)
+on_inv  # unused function (test/functional/test_framework/mininode.py)
+on_mempool  # unused function (test/functional/test_framework/mininode.py)
+on_notfound  # unused function (test/functional/test_framework/mininode.py)
+on_ping  # unused function (test/functional/test_framework/mininode.py)
+on_pong  # unused function (test/functional/test_framework/mininode.py)
+on_reject  # unused function (test/functional/test_framework/mininode.py)
+on_sendcmpct  # unused function (test/functional/test_framework/mininode.py)
+on_sendheaders  # unused function (test/functional/test_framework/mininode.py)
+on_tx  # unused function (test/functional/test_framework/mininode.py)
+on_verack  # unused function (test/functional/test_framework/mininode.py)
+on_version  # unused function (test/functional/test_framework/mininode.py)
+_.optionxform  # unused attribute (test/util/bitcoin-util-test.py)
+OutputMissing  # unused class (test/functional/data/invalid_txs.py)
+_.posix_path  # unused attribute (contrib/macdeploy/custom_dsstore.py)
+profile_with_perf  # unused function (test/functional/test_framework/test_node.py)
+SizeTooSmall  # unused class (test/functional/data/invalid_txs.py)
+SpendNegative  # unused class (test/functional/data/invalid_txs.py)
+SpendTooMuch  # unused class (test/functional/data/invalid_txs.py)
+TooManySigops  # unused class (test/functional/data/invalid_txs.py)
+verify_ecdsa  # unused function (test/functional/test_framework/key.py)

test/lint/lint-python-dead-code.sh

@@ -15,5 +15,5 @@ fi
 
 vulture \
     --min-confidence 60 \
-    --ignore-names "argtypes,connection_lost,connection_made,converter,data_received,daemon,errcheck,get_ecdh_key,get_privkey,is_compressed,is_fullyvalid,msg_generic,on_*,optionxform,restype,set_privkey,*serialize_v2,profile_with_perf" \
-    $(git ls-files -- "*.py" ":(exclude)contrib/" ":(exclude)src/crc32c/" ":(exclude)test/functional/test_framework/address.py")
+    $(git rev-parse --show-toplevel) \
+    $(dirname "${BASH_SOURCE[0]}")/lint-python-dead-code-whitelist