Skip to content

Commit

Permalink
[tests] util_tests.cpp: actually check ignored args
Browse files Browse the repository at this point in the history
An array with 7 elements was setup for checking argument parsing, but
was passed to ParseParamaeters with argc=5, meaning the interpretation
of the last two arguments was never actually checked.
  • Loading branch information
ajtowns committed Jan 3, 2018
1 parent 20166f8 commit c99a3c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/test/util_tests.cpp
Expand Up @@ -121,7 +121,7 @@ BOOST_AUTO_TEST_CASE(util_ParseParameters)
testArgs.ParseParameters(1, (char**)argv_test);
BOOST_CHECK(testArgs.GetMapArgs().empty() && testArgs.GetMapMultiArgs().empty());

testArgs.ParseParameters(5, (char**)argv_test);
testArgs.ParseParameters(7, (char**)argv_test);
// expectation: -ignored is ignored (program name argument),
// -a, -b and -ccc end up in map, -d ignored because it is after
// a non-option argument (non-GNU option parsing)
Expand Down

0 comments on commit c99a3c3

Please sign in to comment.