Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept additional hostnames within compose file. #257

Closed
axisofentropy opened this issue Sep 14, 2022 · 2 comments
Closed

Accept additional hostnames within compose file. #257

axisofentropy opened this issue Sep 14, 2022 · 2 comments

Comments

@axisofentropy
Copy link
Member

Child of https://github.com/UffizziCloud/uffizzi_platform/issues/239#issuecomment-1244492724

Some of our customers need to test additional subdomains pointed to the same Uffizzi Deployment. We should accept these within our compose file along with other Uffizzi configuration.

Example:

x-uffizzi:
  ingress:
    service: app
    port: 80
    additional_subdomains:
      - "example"
      - "example-hostname"

This configuration should be stored with other Uffizzi Deployment configuration and passed along to the controller. The controller will change its behavior if any number of additional hostnames are specified.

Include input validation, error handling, and documentation for this new feature!

@axisofentropy
Copy link
Member Author

If this was implemented, and it looks like it was, then this ticket should be closed.

@gadkins
Copy link
Member

gadkins commented Mar 15, 2023

Implemented here #274

Documented here UffizziCloud/docs#107

@gadkins gadkins closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Working Project Board
New Issues / Investigating
Development

No branches or pull requests

2 participants