util to convert legacy outputs to seraphis lib compatible enotes #22
Conversation
| * outparam: enotes - | ||
| */ | ||
| void legacy_outputs_to_enotes(const cryptonote::transaction &tx, std::vector<LegacyEnoteVariant> &enotes); |
There was a problem hiding this comment.
| * outparam: enotes - | |
| */ | |
| void legacy_outputs_to_enotes(const cryptonote::transaction &tx, std::vector<LegacyEnoteVariant> &enotes); | |
| * outparam: enotes_out - | |
| */ | |
| void legacy_outputs_to_enotes(const cryptonote::transaction &tx, std::vector<LegacyEnoteVariant> &enotes_out); |
| { | ||
| return tx.rct_signatures.type == rct::RCTTypeBulletproof2 || tx.rct_signatures.type == rct::RCTTypeCLSAG || tx.rct_signatures.type == rct::RCTTypeBulletproofPlus; | ||
| } |
There was a problem hiding this comment.
Should be multiple lines. The goal is to keep file width approximately equal to the //-- barriers.
| @@ -554,4 +555,186 @@ void get_legacy_enote_record(const LegacyIntermediateEnoteRecord &intermediate_r | |||
| get_legacy_enote_record(intermediate_record, key_image, record_out); | |||
| } | |||
| //------------------------------------------------------------------------------------------------------------------- | |||
| bool is_encoded_amount_v1(const cryptonote::transaction &tx) | |||
There was a problem hiding this comment.
You seem to be missing header entries for all of these functions.
There was a problem hiding this comment.
They're private helper functions for the exposed legacy_outputs_to_enotes
There was a problem hiding this comment.
In that case they should be static at the top of the file, with doubled-up //-- barriers.
| is_encoded_amount_v2(tx); | ||
| } | ||
| //------------------------------------------------------------------------------------------------------------------- | ||
| bool try_out_to_legacy_enote_v1(const cryptonote::transaction &tx, const size_t output_index, sp::LegacyEnoteVariant &enote) |
There was a problem hiding this comment.
| bool try_out_to_legacy_enote_v1(const cryptonote::transaction &tx, const size_t output_index, sp::LegacyEnoteVariant &enote) | |
| bool try_out_to_legacy_enote_v1(const cryptonote::transaction &tx, const size_t output_index, sp::LegacyEnoteVariant &enote_out) |
etc.
|
@jeffro256 can you review the details of this PR? Then I will merge it. |
| /// C | ||
| enote_v3.amount_commitment = tx.rct_signatures.outPk[output_index].mask; | ||
| /// enc(a) | ||
| const size_t byte_size = sizeof(enote_v3.encoded_amount); |
There was a problem hiding this comment.
| const size_t byte_size = sizeof(enote_v3.encoded_amount); | |
| constexpr size_t byte_size = sizeof(enote_v3.encoded_amount); |
Should technically be constexpr to be used portably in a static_assert expression.
| /// C | ||
| enote_v5.amount_commitment = tx.rct_signatures.outPk[output_index].mask; | ||
| /// enc(a) | ||
| const size_t byte_size = sizeof(enote_v5.encoded_amount); |
| if (output_index >= tx.vout.size()) | ||
| return false; |
There was a problem hiding this comment.
This is a minor performance change, but if you change the function signature of try_out_to_legacy_enote_vx to have a reference const cryptonote::tx_out& (like is_legacy_enote_vx) instead of an output index, then you won't have to check this if branch 5 times for every single enote.
There was a problem hiding this comment.
The reason I didn't do that is because the amount commitments and encrypted amounts aren't on the tx_out, they're in tx.rct_signatures.outPk[output_index] and tx.rct_signatures.ecdhInfo[output_index] respectively, and passing those in by reference and handling each try_out_to_legacy function signature differently felt clunky
There was a problem hiding this comment.
Fair enough... it doesn't matter much either way
j-berman
force-pushed
the
legacy-to-enote-util
branch
from
2f22cad
to
f2a1bbd
Compare
|
Squashed |
j-berman
force-pushed
the
legacy-to-enote-util
branch
from
f2a1bbd
to
84be4d4
Compare
This type conversion is useful to scan legacy txs (returned via the
/getblocks.binRPC endpoint) using the Seraphis wallet lib scanner. Can see it in action in this commit.