modify construct_tx_for_mock_ledger_v1 so it outputs the JamtisPaymentProposals #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
reviewed
Oct 29, 2023
Comment on lines
351
to
365
| construct_tx_for_mock_ledger_v1(local_user_legacy_keys, | ||
| local_user_sp_keys, | ||
| local_user_input_selector, | ||
| tx_fee_calculator, | ||
| fee_per_tx_weight, | ||
| max_inputs, | ||
| outlays, | ||
| legacy_ring_size, | ||
| ref_set_decomp_n, | ||
| ref_set_decomp_m, | ||
| bin_config, | ||
| ledger_context, | ||
| tx_out, | ||
| selfsend_payments, | ||
| normal_payments); |
There was a problem hiding this comment.
Sorry. Looks like I will never get a perfectly formatted PR. Thanks.
UkoeHB
pushed a commit
that referenced
this pull request
Feb 8, 2024
…tProposals (#24) * modify construct_tx_for_mock_ledger_v1 so it outputs the JamtisPaymentProposals --------- Co-authored-by: DangerousFreedom <monero-inflation-checker@protonmail.com>
UkoeHB
pushed a commit
that referenced
this pull request
Mar 6, 2024
…tProposals (#24) * modify construct_tx_for_mock_ledger_v1 so it outputs the JamtisPaymentProposals --------- Co-authored-by: DangerousFreedom <monero-inflation-checker@protonmail.com>
SNeedlewoods
pushed a commit
to SNeedlewoods/seraphis_wallet
that referenced
this pull request
Mar 8, 2024
…tProposals (UkoeHB#24) * modify construct_tx_for_mock_ledger_v1 so it outputs the JamtisPaymentProposals --------- Co-authored-by: DangerousFreedom <monero-inflation-checker@protonmail.com>
SNeedlewoods
pushed a commit
to SNeedlewoods/seraphis_wallet
that referenced
this pull request
Mar 8, 2024
…tProposals (UkoeHB#24) * modify construct_tx_for_mock_ledger_v1 so it outputs the JamtisPaymentProposals --------- Co-authored-by: DangerousFreedom <monero-inflation-checker@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to the construct_tx_for_mock_ledger_v1 mock function so it outputs the JamtisPaymentProposals which will later be stored in the TxHistory after attempting to create a transaction.
Just added another way to call this function instead of using an optional argument and modifying the instances where it appears.