Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for more than one image/file in an media object #11

Closed
hartenthaler opened this issue Feb 20, 2020 · 14 comments
Closed

Support for more than one image/file in an media object #11

hartenthaler opened this issue Feb 20, 2020 · 14 comments
Assignees

Comments

@hartenthaler
Copy link

Webtrees supports since V2 more files/images in one media object. Your module is still working perfect, but the filename in the database field f_m_filename is not the filename of the used image with selected faces, it is the filename of the other file. The only effect is that in the admin screen of your module (which shows the list of all the images with selected faces), the wrong image is shown.

@UksusoFF UksusoFF self-assigned this Feb 20, 2020
@miqrogroove
Copy link

There is another symptom: When sliding between different images for the same media object, the tags are displayed on all of the images, not just the tagged image.

@UksusoFF
Copy link
Owner

UksusoFF commented May 7, 2020

@miqrogroove can you describe steps how to add multiple files to one media?
Also any use cases will helpfull.

@hartenthaler
Copy link
Author

My use case: I like to store the original scanned image in a media object and additionally a second version which is the result from editing the original with Photoshop, for example changing contrast, removing distortions, rotating, and cropping the image. Storing both in one media object helps to keep them together.
It is easy to add a second media file to an already existing media object: edit any media object which contains already an image file; in the last line you can find "add a media file". Then you have two media files in one object.

@miqrogroove
Copy link

My use case is to add the reverse side of a post card. That image is secondary and less useful, but I like to keep the two sides together for easy reference.

@UksusoFF
Copy link
Owner

UksusoFF commented May 7, 2020

Seems at now I can only hide faces on images except first.
Because can't make up how connect data with other images - we have:

  • fact id - but it's changed each time when edit media;
  • images order - but it's also can be changed.

@UksusoFF
Copy link
Owner

UksusoFF commented May 7, 2020

Media filename not available on front end part :(

@miqrogroove
Copy link

Image order should be adequate. If I go to an Album tab and click on the secondary image, the slideshow pops up the second image and allows me to rewind to the first.

@miqrogroove
Copy link

Also, if it's possible, the links should stay visible, and just remove the face rectangles.

@UksusoFF
Copy link
Owner

UksusoFF commented May 7, 2020

Image order should be adequate.

Yep. But you can edit media via gedcom format and order can be changed.

@hartenthaler
Copy link
Author

maybe Greg can help to find a solution

@UksusoFF
Copy link
Owner

UksusoFF commented Jun 22, 2020

Logic for work with multiple files added to master version.
It's depend on media order so when you change it with GEDCOM editor you may got jumbled faces.
Please test it.

@UksusoFF
Copy link
Owner

Seems as fixed. Please reopen if any troubles with it.

@miqrogroove
Copy link

It's much better, and I have a question. When I navigate between the images, both the tags and the sidebar links disappear. I was thinking it would be relevant to keep the sidebar links, and only remove the face tags. Would that make sense? Or were you planning to have different people tagged on each image?

@UksusoFF
Copy link
Owner

Or were you planning to have different people tagged on each image?

Each image now can have independent tags, so it's true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants