Country code conversion review #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for automatic common and unique country extraction, easy country counting and no manual HTML editing.
Refactor for automatic country processing.
This feature allows to store country data in a human-readable way and then convert it to easier to use country codes. Flags work now, expectw for provinces, which need to be handled separatly.
UladBohdan
approved these changes
Nov 11, 2018
| 'Guyana': 'GY', | ||
| 'Haiti': 'HT', | ||
| 'Heard Island and McDonald Islands': 'HM', | ||
| 'Holy See (Vatican City State)': 'VA', |
There was a problem hiding this comment.
I was unsure about the spellings of some countries and if google charts can recognize them - such as Holy See (Vatican City State), Côte d\'Ivoire, Åland Islands etc., but I did verify they work just fine.
Good job!
There was a problem hiding this comment.
Thank you for review and actual verification. I did not check if they worked myself; just believed that Wikipedia listing will have them named in a proper manner and decided that they countries are not the most popular and can be checked when somebody actually visits them.
|
Not merging this. |
As some countries are visualized on a region level, we would like these regions to be grouped together in a single entry. Additionally, this patch takes care of visual discrepancy between these fine-grained region codes and simple country name. As a side effect, names in data.js can be specified by either full name of by 2 letter country code.
Aggregate provinces of a single country to a single table row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the latest commits related to country code conversion.
Don't scroll the conversion map all the way down straight away. Give it some attention as I was generating it with macros and might have screwed up somewhere.
Additionally, all the flags including the ones for provinces should be visible now. The world maps still don't show these provinces as well as there's no aggregation in the list for these fine-grained countries.
Note: I pushed straight to a dev branch, my changes got clustered together with the previous ones and it's a bit hard to review everything right now. Sorry about that. Just cancel the merge request if you think everything is fine. Next time I will make a separate branch for a new feature and make a pull request to the dev branch.