-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher not closing after opening application #1381
Comments
What's the output of |
Or actually nvm I guess it says 6.0.0-beta10 in the log. I can't reproduce this in my environment so help would be appreciated. Does it only happen with terminal apps? |
This is happening to me as well with every app on Ubuntu 22.04 LTS (also on beta10). Checking with |
Thanks @Supreeeme! This gives me a pretty good idea of how this was caused and probably how to fix it. |
I think bce7010 may have broken it, but I'm not sure. Could you test if this works in v6.0.0-beta6 but not v6.0.0-beta7? |
idk how to do this with flakes |
Just specify the rev @DADA30000 https://nixos.org/manual/nix/unstable/command-ref/new-cli/nix3-flake#examples |
The intended behavior for Ulauncher is to hide the window when you lose focus, but also to hide it when you launch an app. Both have to fail for Ulauncher to stay open. For me, the former never failed before, but shortly after the other issue was raised I managed to replicate it with multiple monitors for one specific app. Since I was not at home and did not have time to work on Ulauncher when this happened I could only put a few minutes on it. I made it work for that situation, and found that I had to return True instead of False in one location, so I figured I probably messed the semantics up in the refactoring PR that introduced this. However that wasn't the case, and instead I got it wrong in the hotfix, but with the hotfix + the focus out behavior it would work for me 100% of the time. Now I managed to test it some more and reverted the former hotfix in 3efdc94. I tried to replicate the issue but haven't been able to (not for lacking monitors to test with). So please test again with the v6 branch. Also @Thanatermesis can you confirm if it works for you too now or if the issue was reintroduced/never fixed for you? |
And I'd like to understand why this doesn't seem to trigger for wlr-users? Ulauncher/ulauncher/ui/windows/UlauncherWindow.py Lines 131 to 133 in 3efdc94
|
Latest release includes the new changes: |
I'll close the issue. But if you still get the problem after updating, write a comment. |
yep, now it works as it should be |
I can confirm it works on my side too |
Environment
Hyprland, NixOS 24.05
Bug description
I'm using 6.0.0-beta10, in release notes it was said that this problem was fixed, but it's not fixed.
When I'm opening an app through ulauncher, ulauncher is not being closed afterwards
Log output
Communication guidelines
Ulauncher v6
The text was updated successfully, but these errors were encountered: