Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have tests in GitHub assets #390

Open
worldofpeace opened this issue Jun 1, 2019 · 2 comments
Open

Have tests in GitHub assets #390

worldofpeace opened this issue Jun 1, 2019 · 2 comments
Labels
enhancement Improvement to an existing feature

Comments

@worldofpeace
Copy link

We'd like to add Ulanucher to nixpkgs NixOS/nixpkgs#57859.
I'd like to be able to run the tests within the source distribution, a common practice in most distros.
However they aren't included, can you please consider doing this?

Currently to run tests I'd have to use the regular GitHub generated tarball, but this lacks the preferences prebuilt. And currently in nixpkgs we lack a way to use yarn internally.

@gornostal
Copy link
Member

If I understand your request correctly, source tarrball generated by default is not working for you because it doesn't have preferences pre-built, and a tarball generated by Ulauncher CI process is lacks the tests, right?

I'm not sure I want to include tests into the tarball because they are run when the release is generated.

@worldofpeace
Copy link
Author

Yes we'd like the tests at https://github.com/Ulauncher/Ulauncher/tree/dev/tests in these assets https://github.com/Ulauncher/Ulauncher/releases/download/5.3.0-beta1/ulauncher_5.3.0.beta1.tar.gz

I'm not sure I want to include tests into the tarball because they are run when the release is generated.

There is a strong precedent in distros to be able to run tests in packages.
This allows us to verify the dependencies packaged by our distribution are compatible with the package and it installs successfully. (nixpkgs moves very quickly).
Off the top of my head distros like Debian and Gentoo have dedicated testing phases for this exact purpose.

@gornostal gornostal added the enhancement Improvement to an existing feature label Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants