v1.1.0 : Removed unnecessary null pointer checks #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elfring
reviewed
Nov 3, 2016
| @@ -105,13 +102,25 @@ cache_manager_iface* cache_manager::operator->() { return this->ptr; } | |||
|
|
|||
| const cache_manager_iface* cache_manager::operator->() const { return this->ptr; } | |||
|
|
|||
| bool operator==(std::nullptr_t nullp, const cache_manager& p) { return p.ptr == nullp; } | |||
There was a problem hiding this comment.
Should such a source code layout change for equality comparison functions belong to an other commit?
There was a problem hiding this comment.
Yes, it should. My mistake! Thank you for pointing that out :)
|
Thanks for your small source code improvement. |
|
@elfring Well, thank you for your contribution. It's very nice of you! |
Ullaakut
pushed a commit
that referenced
this pull request
Nov 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.