Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Disgo usable as a global logger #17

Merged
merged 2 commits into from
Mar 11, 2019
Merged

Make Disgo usable as a global logger #17

merged 2 commits into from
Mar 11, 2019

Conversation

Ullaakut
Copy link
Owner

Goal of this PR

  • Add a default logger variable that is not public but can be used through functions that are exactly the same as the methods normally accessible on a logger
  • Add a function SetGlobalOptions to set options on the global logger
  • Add an example main to show that the global logger is thread-safe and works

@Ullaakut Ullaakut added the enhancement New feature or request label Mar 11, 2019
@Ullaakut Ullaakut self-assigned this Mar 11, 2019
@Ullaakut Ullaakut requested a review from jlevesy March 11, 2019 16:51
jlevesy
jlevesy approved these changes Mar 11, 2019
View reviewed changes
Copy link
Collaborator

@jlevesy jlevesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ullaakut Ullaakut merged commit 8dea5e0 into master Mar 11, 2019
@Ullaakut Ullaakut deleted the global-logger-experiment branch March 11, 2019 17:12
@Ullaakut Ullaakut mentioned this pull request Mar 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlevesy jlevesy jlevesy approved these changes

Assignees

@Ullaakut Ullaakut

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ullaakut @jlevesy