Add staticcheck to actions (#96)

.github/workflows/build.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
 
       - name: Cache Go modules
         uses: actions/cache@v2

.github/workflows/test.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.16
+          go-version: 1.17
 
       - name: Cache Go modules
         uses: actions/cache@v2
@@ -58,3 +58,9 @@ jobs:
         env:
             COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: goveralls -coverprofile=c.out -service=github
+
+      - name: Install staticcheck
+        run: go install honnef.co/go/tools/cmd/staticcheck@latest
+
+      - name: Run staticcheck for possible optimizations
+        run: staticcheck -tests=false

iflist.go

@@ -67,16 +67,18 @@ func parseInterfaces(content []byte) *InterfaceList {
 	output := string(content)
 	lines := strings.Split(output, "\n")
 
+	interfaceRegex := regexp.MustCompile(`\*INTERFACES\*`)
+	routesRegex := regexp.MustCompile(`\*ROUTES\*`)
 	for i, line := range lines {
-		if match, _ := regexp.MatchString(`[\*]INTERFACES[\*]`, line); match {
+		if interfaceRegex.MatchString(line) {
 			for _, l := range lines[i+2:] {
 				if iface := convertInterface(l); iface != nil {
 					list.Interfaces = append(list.Interfaces, iface)
 				}
 			}
 		}
 
-		if match, _ := regexp.MatchString(`[\*]ROUTES[\*]`, line); match {
+		if routesRegex.MatchString(line) {
 			for _, l := range lines[i+2:] {
 				if route := convertRoute(l); route != nil {
 					list.Routes = append(list.Routes, route)

nmap.go

@@ -329,9 +329,7 @@ func (s *Scanner) RunWithStreamer(stream Streamer, file string) (warnings []stri
 	// Process nmap stderr output containing none-critical errors and warnings.
 	// Everyone needs to check whether one or some of these warnings is a hard issue in their use case.
 	if stderrBuf.Len() > 0 {
-		for _, v := range strings.Split(strings.Trim(stderrBuf.String(), "\n"), "\n") {
-			warnings = append(warnings, v)
-		}
+		warnings = append(warnings, strings.Split(strings.Trim(stderrBuf.String(), "\n"), "\n")...)
 	}
 
 	// Check for warnings that will inevitably lead to parsing errors, hence, have priority.