Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch test and build to GitHub actions #91

Merged
merged 7 commits into from
Aug 23, 2021
Merged

Switch test and build to GitHub actions #91

merged 7 commits into from
Aug 23, 2021

Conversation

elivlo
Copy link
Collaborator

@elivlo elivlo commented Aug 18, 2021 •
edited
Loading

This PR will remove travis-ci and now uses GitHub actions to build, test and push the test result to "coveralls.io".

  • The action build will run when there is a change in the example folder
  • The action test will run when changes were made in any .go file.

@elivlo elivlo changed the title Create test.yml Create GitHub action to test this package with coverage Aug 19, 2021
@elivlo elivlo force-pushed the switch-from-travis-to-actions branch 2 times, most recently from 7ec7689 to 96466e5 Compare August 19, 2021 13:09
@elivlo elivlo marked this pull request as ready for review August 19, 2021 13:10
@elivlo elivlo self-assigned this Aug 19, 2021
@elivlo elivlo changed the title Create GitHub action to test this package with coverage Switch test and build to GitHub actions Aug 19, 2021
@elivlo elivlo requested a review from Ullaakut August 19, 2021 13:18
@elivlo elivlo force-pushed the switch-from-travis-to-actions branch from 84c2e13 to fef4f1a Compare August 19, 2021 16:06
@elivlo elivlo force-pushed the switch-from-travis-to-actions branch from fef4f1a to 77f28ef Compare August 19, 2021 16:08
Ullaakut
Ullaakut reviewed Aug 20, 2021
View reviewed changes
Copy link
Owner

@Ullaakut Ullaakut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent initiative @elivlo ! You're giving a second life to the project with PRs like this one :D

I have a few small suggestions, let me know what you think

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
nmap_test.go Show resolved Hide resolved
@elivlo @Ullaakut
Apply suggestions from code review
78008cb 
Co-authored-by: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
@elivlo elivlo force-pushed the switch-from-travis-to-actions branch from 0b93b31 to 78008cb Compare August 20, 2021 12:14
@Ullaakut
Copy link
Owner

Last thing to do before this can be merged, run the following command and push the resulting changes:

go mod tidy ; go fmt ./...

Great work 👍

@elivlo
Copy link
Collaborator Author

elivlo commented Aug 23, 2021

Thanks! 😃

@elivlo elivlo merged commit 0579288 into master Aug 23, 2021
@elivlo elivlo deleted the switch-from-travis-to-actions branch January 19, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ullaakut Ullaakut Ullaakut approved these changes

Assignees

@elivlo elivlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elivlo @Ullaakut