Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --unique and --script-timeout flags #99

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

Ullaakut
Copy link
Owner

Goal of this PR

Fixes #97

Adds support for the flags found at:

And adds unit tests.

@Ullaakut Ullaakut added the enhancement New feature or request label Jul 22, 2022
@Ullaakut Ullaakut requested a review from elivlo July 22, 2022 17:15
@Ullaakut Ullaakut self-assigned this Jul 22, 2022
@Ullaakut
Copy link
Owner Author

Will force merge soon if no reviews

Copy link
Collaborator

@elivlo elivlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elivlo
Copy link
Collaborator

elivlo commented Aug 23, 2022

Sorry for the late review! I was busy learning for exams.

@elivlo elivlo merged commit f32c1a8 into master Aug 23, 2022
@Ullaakut
Copy link
Owner Author

@elivlo no worries, there was no rush :)

@elivlo elivlo deleted the add-unique-and-script-timeout-flags branch February 22, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not support --unique --script-timeout 3m
2 participants