Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple ranges bugfixes #617

Merged
merged 2 commits into from
Sep 30, 2020
Merged

Multiple ranges bugfixes #617

merged 2 commits into from
Sep 30, 2020

Conversation

Geegee
Copy link
Contributor

@Geegee Geegee commented Sep 30, 2020

Bugfix to the recently merged mutliple_ranges_odmr.

Description

A list was not properly resetted between different ODMR runs.

Motivation and Context

Making the ODMR Gui usable again.

How Has This Been Tested?

Check on dummy configuraton.

Screenshots (only if appropriate, delete if not):

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

Copy link
Contributor

@NicolasStaudenmaier NicolasStaudenmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably my bad not having it noticed. Thanks for immediate correction.

@Geegee Geegee merged commit 1d1e095 into master Sep 30, 2020
@kay-jahnke kay-jahnke deleted the multiple_ranges_bugfixes branch October 16, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants