Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save fit in ranges #686

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Save fit in ranges #686

wants to merge 7 commits into from

Conversation

Geegee
Copy link
Contributor

@Geegee Geegee commented Sep 30, 2021

Previously -1 was introduced as an indicator for all ranges combined.
Now this is followed through the whole tool chain.

Description

This includes:
- saving
- display of the whole matrix range
Additionally some clarifying tool tips were added.

Motivation and Context

This should bring as added benefit the changes intended in #681

How Has This Been Tested?

On dummy. I tried saving under different scenarios. Certainly not exhaustive.

Screenshots (only if appropriate, delete if not):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have documented my changes in the changelog (documentation/changelog.md)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added/updated for the module the config example in the docstring of the class accordingly.
  • I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).
  • I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.
  • All changed Jupyter notebooks have been stripped of their output cells.

@NicolasStaudenmaier NicolasStaudenmaier added this to In progress in CW ODMR via automation Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
CW ODMR
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants