Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop file invalid #1784

Closed
hroncok opened this issue May 3, 2017 · 2 comments
Closed

Desktop file invalid #1784

hroncok opened this issue May 3, 2017 · 2 comments
Assignees
@awhiemstra

Comments

@hroncok
Copy link
Contributor

hroncok commented May 3, 2017

Application Version: 2.5.0
Platform: Linux (Fedora 27 to be precise, but this would happen on other Linuxes as well)
Qt: not relevant
PyQt: not relevant
Display Driver: not relevant

Steps to Reproduce:

cmake ...
make
cmake install ...
desktop-file-validate /usr/share/applications/cura.desktop

Actual Results:

/usr/share/applications/cura.desktop: error: value "1" for key "Version" in group "Desktop Entry" is not a known version

Expected results:

(empty)

Additional Information:
The latest specification says:

Version of the Desktop Entry Specification that the desktop entry conforms with. Entries that confirm with this version of the specification should use 1.1. Note that the version field is not required to be present.
awhiemstra added a commit to Ultimaker/cura-build that referenced this issue May 3, 2017
@awhiemstra
Remove Version field from Desktop file
47e1b2a 
Apparently, it is not a required field and we specify an incorrect version.

See also Ultimaker/Cura#1784
@hroncok
Copy link
Contributor Author

hroncok commented May 3, 2017

Thanks for fixing.

@probonopd
Copy link
Contributor

probonopd commented Aug 18, 2017 •
edited

Still invalid in 2.6.2:

cura.desktop: error: (will be fatal in the future): value "cura-icon.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path

Solution: Remove .png

cura.desktop: error: value "application/sla;application/vnd.ms-3mfdocument;application/prs.wavefront-obj;image/bmp;image/gif;image/jpeg;image/png" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character

Solution: Add ;

Reference:
https://travis-ci.org/AppImage/AppImageHub/builds/266072586#L538-L539

probonopd added a commit to probonopd/Cura that referenced this issue Aug 18, 2017
@probonopd
Make it pass desktop-file-validate, closes Ultimaker#1784
b9970d5 
```
cura.desktop: error: (will be fatal in the future): value "cura-icon.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path
```
__Solution:__ Remove `.png`. __PLEASE NOTE__ that for this to work, cura-icon.png must be located in one of the directories in which desktops search for icons, such as `/usr/share/icons/hicolor/128x128/apps/`. Please make sure it ends up there (also in the AppImage, too.)

```
cura.desktop: error: value "application/sla;application/vnd.ms-3mfdocument;application/prs.wavefront-obj;image/bmp;image/gif;image/jpeg;image/png" for string list key "MimeType" in group "Desktop Entry" does not have a semicolon (';') as trailing character
```
__Solution:__ Add `;`

Reference:
https://travis-ci.org/AppImage/AppImageHub/builds/266072586#L538-L539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awhiemstra awhiemstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hroncok @probonopd @awhiemstra