Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress percentage on the software do not match the display on the CR-10S #6019

Closed
CGLee65 opened this issue Jul 16, 2019 · 8 comments
Closed
Labels
Status: Needs Info Needs more information before action can be taken. Type: Bug The code does not produce the intended behavior.

Comments

@CGLee65
Copy link

CGLee65 commented Jul 16, 2019

The Completed % on the software shows like 4% and the Display on the control box says 0%

@CGLee65 CGLee65 added the Type: Bug The code does not produce the intended behavior. label Jul 16, 2019
@rburema
Copy link
Member

rburema commented Jul 17, 2019

There's some known (and unkown) issues with progress reporting / time estimation / etc. One thing to keep in mind is that it's an estimation, especially for printers we can't often test with.

Does this discrepancy become wildly out of sync or does it stay within certain limits?

@CGLee65
Copy link
Author

CGLee65 commented Jul 17, 2019 via email

@Ghostkeeper
Copy link
Collaborator

Ghostkeeper commented Jul 17, 2019

The printer doesn't know the progress when printing via USB cable. The slicer software is sending the g-code commands on the go.

There is no way for Cura to communicate progress to a CR-10S via USB cable. The only g-code that Cura could use for that is M532 but that's only supported for Repetier, according to the RepRap wiki.

@yet-another-average-joe
Copy link

yet-another-average-joe commented Jul 17, 2019

Marlin, MK4Duo and Makerbot have M73 that displays a percentage on the LCD :

http://marlinfw.org/docs/gcode/M073.html

https://reprap.org/wiki/G-code#M73:_Set_build_percentage

The CR10 runs Marlin (and most chinese printers probably do).

(it is used by a couple of OctoPrint plugins)

@fieldOfView
Copy link
Collaborator

M73 support needs to be specifically enabled in Marlin, so it will not work on all printers.

This feels like something that maybe should be implemented in a postprocessing plugin, calculating progress from the ";TIME_ELAPSED" comments that CuraEngine puts into the gcode after each layer.

@yet-another-average-joe
Copy link

yet-another-average-joe commented Jul 17, 2019

I was just thinking of the Cura Post Processing Plugin, and realized that as is, it could be based on layer # only, and it does not make sense !

I thought that LCD_SET_PROGRESS_MANUALLY was ON by default. I was wrong...

@LinFor
Copy link

LinFor commented Oct 3, 2019

I wrote simple post-processing script to do thins on Marlin: https://github.com/LinFor/Marlin/blob/e-bot-skr/cura-profiles/scripts/EnrichPrintProgress.py
It's just use TIME_ELAPSED layer estimation from Cura and converts it into M73/M117 commands. Maybe later I approximate progress more precisely within layer (by E-movements, for example) to do more reliable progress estimation for short prints or very big layers.

Also, currently Marlin ignores M73 command when printing from SD card (so it's the only reason to produce M117 commands), I wrote PR for Marlin to fix this, please vote for my PR if this functionality is important to you: MarlinFirmware/Marlin#15449

@GregValiant GregValiant added the Status: Needs Info Needs more information before action can be taken. label Sep 15, 2023
@github-actions
Copy link
Contributor

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Info Needs more information before action can be taken. Type: Bug The code does not produce the intended behavior.
Projects
None yet
Development

No branches or pull requests

7 participants