Display Info on LCD #15866
Display Info on LCD #15866
Conversation
github-actions
bot
added
the
PR: Community Contribution 👑
These two files become obsolete if DisplayInfoOnLCD is accepted.
Remove code that added the PP name to the gcode. Create DisplayInfoOnLCD.py This post processor combines DisplayLayerAndFilename with DisplayProgress. Those two post processors would be obsolete.
Added TimeToPause to DisplayProgress
Get the current print time estimate, adjust it by the Fudge Factor, and add it to the current time +10 minutes (to actually start the print.) Update DisplayInfoOnLCD.py Change message format for Finish Time Estimate.
Changed "name" variable to "file_name" to avoid any conficts.
Add a line below the ";TIME:" line to convert "seconds" to Hours:Minutes
|
I was researching something else and came across a fact I had completely missed - RepRap can use M566 for Jerk in mm/min. |
There was a problem hiding this comment.
Hi Greg!
The big problem I have with this is that when you save a project, it saves which (post-processing) scripts where used as well. If it can't find them, it just ignores them -- which means that if the (now) removed scripts are added to a project, they'll no longer work, nor do they use the new script.
There's a number of ways to handle this.
- Writing an upgrade-script would be the most proper, but also the hardest (and I'm not sure if we can do that for upgrade scripts -- though it should be possible). Maybe a bit overkill?
- Leaving the scripts in, but messaging the user that the older scripts are deprecated.
- Only leaving shells of the scripts, and only leave functionality in there to message the user.
- Rewriting the scripts so that they inherit from the new one.
- Not do anything (so reinstate them) and just have them live side-by-side until the next major version of Cura.
- ... or I can ask the rest of the team if it's ok that we just rip these out and just communicate the change well.
|
The project file situation is something I hadn't thought of. As a user I think I would prefer a quick message to inform me to move to the new post processor. If the script is left in then there is no incentive to move on and people will keep using it. I've made changes to the two original scripts and turned them into "dummies" that just give messages. What is your preference in handling this? In addition, I made some additions and made another commit. It will have the two changes you requested. It does not have the other two files in it. |
Added Print Finish Time option. Changed a couple of if statements to "line.startswith".
|
Remco, |
Add pause count notification Update DisplayInfoOnLCD.py Moved some line insertions to accommodate newer Creality firmware. Change DisplayFIlename and DIsplayProgress Add messages to use DIsplay Info and add exit code. Update DisplayInfoOnLCD.py Some changes
There was a problem hiding this comment.
Hi Greg,
Sorry for the wait (again... it's been quite busy here).
I think we can accept this now. I have noticed that this doesn't 100% replace the other two scripts (the possibility to set M73 instead of M117/8 is missing, and the update-frequency can only be once per layer), but I think this adds enough (and the consolidation itself is also a good thing), that it's still a good improvement. -- So let's just wait to see if anyone complains about those little thing.
Thanks again for the contribution, and I'll try to take another look at the other PRs again next week. (That big list was/is useful.)
|
I've observed some bugs in the new plugin: DisplayInfoOnLCD.py |
Description
DisplayInfoOnLCD combines DisplayFilenameAndLayerOnLCD with DisplayProgress. Those two post processors become options within the single post processor and the two previous files become obsolete. There is an option to add an M118 line as well as M117 so the info would get bounced back to a print server.
There is another pull request #11846 that involves "Display Progress on LCD" and BTREE firmware.
The Aug 12 commit adds "Countdown to Pauses" option when "Display Progress" is selected.
The Sep 8 commit adds an "Estimated Print Finish Time" message as an option per request #16677. #6019
Oct 20 commit adds a comment below the TIME: line and converts "seconds" to Housr:Minutes:Seconds with a pause and/or filament change count.
;TIME:14071
;Filament used: 13.3238m
;Layer height: 0.2
;Cura Time Estimate: 14071sec = 3hr 54min 31sec with 1 pause(s) and 1 filament change(s)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: