New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.5] Comments removed from Start/End G-codes when opening from .3mf #7304
Comments
Hi @Block137 I am not able to reproduce this, my comments at the beginning of start/end g-code starting with (;) are still visible after loading the project file. Did you use any other characters? Do you still have Marlin as g-code flavor? |
@Vandrasc I think you may need to remove the printer in between the steps, I got it to reproduce if I did that (and had multiple ';' in each start/end gcode). |
@Vandrasc the very first line isn't affected, any other commented line will be removed. I'm using Marlin (volumetric) |
Nice! Oke good thing it is reproducible, that makes it easier for us to fix. I will bring it up with our devs, thank you for reporting it! |
@Vandrasc, there is now a PR to bring up too. |
PR was really small & made sense so I merged it as a 5 minute fix. For internal QA: See jira ticket CURA-7315 |
Application version
4.5
Platform
Win10
Printer
Custom
Reproduction steps
Actual results
MOST comment only lines (lines starting with ";") were removed. Comments following actual G-codes (
G28 ;home
for example) remain unchanged.Commented first line didn't get removed.
Expected results
Whole G-code scripts remain unchanged.
Project file
(For slicing bugs, provide a project which clearly shows the bug, by going to File->Save. For big files you may need to use WeTransfer or similar file sharing sites.)
Additional information
This is similar to #6689 but different condition.
The text was updated successfully, but these errors were encountered: