-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
official profiles for Geeetech printers #13973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
All issue items processed. |
Changes requested by the bot have been made, and conversations resolved. Let me know if any additional items are needed or if there are any questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
"material_initial_print_temperature": { "value": "material_print_temperature - 5" }, | ||
"material_flow_layer_0": { "value": 95 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding material_initial_print_temperature with the same value (material_print_temperature - 5) as defined in parent definition: Geeetech_base
"material_initial_print_temperature": { "value": "material_print_temperature - 5" }, | |
"material_flow_layer_0": { "value": 95 }, | |
"material_flow_layer_0": { "value": 95 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the redundant-override problem.
Can't merge this yet, since it has failing UnitTests, See https://github.com/Ultimaker/Cura/actions/runs/3664838630/jobs/6195513166#step:13:549 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the failing UnitTests
LGTM; Thank you for your contribution, will merge this to main, they should be available in Cura 5.3 |
After Cura5.3.1, it was found that this configuration was merged or replaced. Please help restore this configuration file, thank you |
Re-modify and add some series of printer parameter configurations.
24 Geeetech printers, including 9 series models.
Thunder series. A high-speed printer and the maximum printing speed can reach 300 mm/s.
Mizar series. A machine that has very exquisite print quality and ultra quiet printing.
Other Geeetech printers.
---Request from Geeetech offical . All relevant tests have passed.