Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

official profiles for Geeetech printers #13973

Merged
merged 11 commits into from
Dec 13, 2022
Merged

Conversation

whoseyoung
Copy link
Contributor

Re-modify and add some series of printer parameter configurations.

24 Geeetech printers, including 9 series models.
Thunder series. A high-speed printer and the maximum printing speed can reach 300 mm/s.
Mizar series. A machine that has very exquisite print quality and ultra quiet printing.
Other Geeetech printers.
---Request from Geeetech offical . All relevant tests have passed.

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Dec 5, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

resources/definitions/geeetech_GiantArmD200.def.json Outdated Show resolved Hide resolved
@whoseyoung
Copy link
Contributor Author

All issue items processed.

@whoseyoung whoseyoung changed the title official profile for Geeetech printers official profiles for Geeetech printers Dec 8, 2022
@whoseyoung
Copy link
Contributor Author

Changes requested by the bot have been made, and conversations resolved. Let me know if any additional items are needed or if there are any questions.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

Comment on lines 51 to 52
"material_initial_print_temperature": { "value": "material_print_temperature - 5" },
"material_flow_layer_0": { "value": 95 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ diagnostic-definition-redundant-override ⚠️
Overriding material_initial_print_temperature with the same value (material_print_temperature - 5) as defined in parent definition: Geeetech_base

Suggested change
"material_initial_print_temperature": { "value": "material_print_temperature - 5" },
"material_flow_layer_0": { "value": 95 },
"material_flow_layer_0": { "value": 95 },

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the redundant-override problem.

@jellespijker
Copy link
Member

Can't merge this yet, since it has failing UnitTests, See https://github.com/Ultimaker/Cura/actions/runs/3664838630/jobs/6195513166#step:13:549

Copy link
Member

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the failing UnitTests

@MariMakes MariMakes added the PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions label Dec 13, 2022
@jellespijker
Copy link
Member

LGTM;

Thank you for your contribution, will merge this to main, they should be available in Cura 5.3

@whoseyoung
Copy link
Contributor Author

After Cura5.3.1, it was found that this configuration was merged or replaced. Please help restore this configuration file, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants