Allow for expressions in start/end machine/extruder code extruder_nr field

[casperlamboo]

Description

When using templated string variables in start/end machine/extruder gcode users may enter an optional extruder nr {expr[, extruder_nr]}. When providing an extruder_nr the expression is evaluated using the extruder stack with the provided extruder_nr. However, this workflow was broken when providing a variable that would evaluate to an extruder nr. E.g. the start code M140 S{material_bed_temperature, 0} will produce the expected result but M140 S{material_bed_temperature, initial_extruder_nr} wouldn't.

This was an oversight when implementing #16962, before merging this PR we did already support this behavior.

fixes #17501
CURA-11536

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Printer definition file(s)
• Translations

How Has This Been Tested?

YEs

Test Configuration:

• Operating System: MacOS 13.3

Checklist:

• My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
• I have read the Contribution guide
• I have commented my code, particularly in hard-to-understand areas
• I have uploaded any files required to test this change

[bellzw]

Will this fix the problem of 5.6.0 generating code like M109 T0 S(200.0, 0)? It should be M109 T0 S200.0. Parentheses should not be present, and neither should the 2nd parameter.

[wawanbreton]

Will this fix the problem of 5.6.0 generating code like M109 T0 S(200.0, 0)? It should be M109 T0 S200.0. Parentheses should not be present, and neither should the 2nd parameter.

Yes indeed, that's the exact purpose of this fix 😃 you can now use a variable as the extruder index.

[bellzw]

OK, good. Thanks. There was also an issue related to incorrect substitution of initial_extruder_nr in the startup gcode, with the value differing from the value inserted by Cura at first executable line of gcode. I provided examples of it in a pdf in my last comment in #17501; it seems to be related to settings of Skirt/Brim Extruder. From: Erwan MATHIEU ***@***.***> Sent: Wednesday, January 17, 2024 2:32 AM To: Ultimaker/Cura ***@***.***> Cc: bellzw ***@***.***>; Comment ***@***.***> Subject: Re: [Ultimaker/Cura] Allow for expressions in start/end machine/extruder code extruder_nr field (PR #18025) Will this fix the problem of 5.6.0 generating code like M109 T0 S(200.0, 0)? It should be M109 T0 S200.0. Parentheses should not be present, and neither should the 2nd parameter. Yes indeed, that's the exact purpose of this fix 😃 you can now use a variable as the extruder index. — Reply to this email directly, <#18025 (comment)> view it on GitHub, or <https://github.com/notifications/unsubscribe-auth/AMFTMUIDIKPD7RUVFMS5TVLYO55ALAVCNFSM6AAAAABB3CYR2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVGIZTIOBUGE> unsubscribe. You are receiving this because you commented. <https://github.com/notifications/beacon/AMFTMUKYXXDF45KTB7HQQ6TYO55ALA5CNFSM6AAAAABB3CYR2CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTQ636RS.gif> Message ID: < ***@***.***> ***@***.***>