Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #16249 .
After looking at my logs (pretty much identical to this), I decided to take a deeper look into the code. As it turns out, 32 tty ports were being tested, 4 at a time, with 15s timeout, twice each. This would give me an expected wait of 32 * 15 * 2 / 4 = 240s of wait, or about 4 minutes. My logs actually match this expected time, so it took Cura 4 minutes between me selecting a file to open and it actually opening on Cura.
Ideally, this wouldn't be a hard-coded
True
. But I'm not that familiar with Qt - or the Cura project as a whole - so I wouldn't know the best way to handle this. Some suggestions are:False
.Type of change
How Has This Been Tested?
I had the same problem as listed on #16249. After building with the new source code, it opened files quickly - as expected.
Checklist: