Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hole Horizontal Expansion setting. #7010

Merged
merged 1 commit into from Feb 13, 2020

Conversation

smartavionics
Copy link
Contributor

Provide simple solution for #2158.

@rburema
Copy link
Member

rburema commented Feb 13, 2020

I'm going to merge this, but for completions sake I will note a few things:

  • While the possibility that it'll ever come up in a real world example and the behaviour isn't wanted is low: If you put Horizontal Expansion high enough that it merges spikes (creating holes) those holes will also be expanded.
  • From a code-clarity perspective, it would'be been a bit more clear to put this where the other ('normal') horizontal expansion takes place.

@rburema rburema merged commit 958f1a8 into Ultimaker:master Feb 13, 2020
@smartavionics
Copy link
Contributor Author

Feel free to move the setting elsewhere if you wish.

@rburema
Copy link
Member

rburema commented Feb 13, 2020

Feel free to move the setting elsewhere if you wish.

I know, just a bit strapped for time right now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants