Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simplify leaving way too small line segments. #1321

Merged
merged 15 commits into from Sep 17, 2020
Merged

Fix simplify leaving way too small line segments. #1321

merged 15 commits into from Sep 17, 2020

Commits on Sep 10, 2020

  1. Don't take the length of the next line into account. 

    CURA-7709
    @nallath
    nallath committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    d7a37e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. Fix degenerate case in simplify by moving point 

    CURA-7709
    @nallath
    nallath committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    979b303 View commit details
    Browse the repository at this point in the history

  2. Prevent wrong segmen 1mu segment generation 

    Fix as suggested by @skarasov

CURA-7709
    @nallath
    nallath committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    80b472c View commit details
    Browse the repository at this point in the history

  3. Use height constraint instead of distance 

    As per suggestion of Tim

CURA-7709
    @nallath
    nallath committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    e75bbf3 View commit details
    Browse the repository at this point in the history

  4. Simplify the if statement 

    CURA-7709
    @nallath
    nallath committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    b5996eb View commit details
    Browse the repository at this point in the history

  5. Remove copypaste error 

    CURA-7709
    @nallath
    nallath committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    22fafe2 View commit details
    Browse the repository at this point in the history

  6. Space after if 

    CURA-7709
    @nallath
    nallath committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    c9a8acd View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Updated documentation 

    CURA-7709
    @nallath
    nallath committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    c350b38 View commit details
    Browse the repository at this point in the history

  2. Add missing visualisation for test 

    CURA-7709
    @nallath
    nallath committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    600055f View commit details
    Browse the repository at this point in the history

  3. Leave in >5 mu line segments if we can't find a better spot for them 

    CURA-7709
    @nallath
    nallath committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    e749149 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded continue 

    CURA-7709
    @nallath
    nallath committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    3fcf1e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Let the lineLineIntersection function use reference instead of pointer 

    CURA-7709
    @nallath
    nallath committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    59030d0 View commit details
    Browse the repository at this point in the history

  2. Move LineLineIntersection function to linearalg2d 

    CURA-7709
    @nallath
    nallath committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    d24f55d View commit details
    Browse the repository at this point in the history

  3. Update documentation of simplify again 

    CURA-7709
    @nallath
    nallath committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    ad750ee View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. Some minor typing and performance fixlets. 

    Likely already adressed by the compiler, but good to be safe.

part of CURA-7709
    @rburema
    rburema committed Sep 17, 2020
    6 Configuration menu
    Copy the full SHA
    5fe2564 View commit details
    Browse the repository at this point in the history