[CURA-9860] fix extra support layer when raft is enabled #1834

rburema · 2023-02-15T19:23:17Z

There was an extra layer of support between the raft and the model, even if the air-gap was set to 0.

The reason given to sometimes do it anyway was not valid anymore anyway. (The setting isn't hidden by support now.) This was complicating the search for a bug; it's probably that we calculate one too many layers when a raft is present. done as part of CURA-9860

The distance between the raft and the first layer should remain the same, regardless of the 'layer 0 overlap', for the settings as currently written. Wrongly compensating it like this leads to it always reporting 1 layer or a gap, even though both the air-gap and the 'layer 0 overlap' are both 0. Just remove it then. part of CURA-9860

The 1st layer of the model is layer 0. This piece of code assumed layer 0 was part of the raft or the air-gap. Also consolidate if-statements. done as part of CURA-9860

github-actions · 2023-02-15T19:29:42Z

Unit Test Results

25 tests ±0 25 ✔️ ±0 11s ⏱️ -4s
  1 suites ±0   0 💤 ±0
  1 files ±0   0 ❌ ±0

Results for commit a5a75fc. ± Comparison against base commit d94ec63.

♻️ This comment has been updated with latest results.

casperlamboo

I was wondering if this comment still makes sense with the proposed changes

CuraEngine/include/raft.h

Lines 23 to 30 in a5a75fc

    
               /*! 
        
                * \brief Get the height difference between the raft and the bottom of 
        
                * layer 1. 
        
                *  
        
                * This is used for the filler layers because they don't use the 
        
                * layer_0_z_overlap. 
        
                */ 
        
               static coord_t getZdiffBetweenRaftAndLayer1();

src/raft.cpp

Enact reviewer comments. done as part of CURA-9860

rburema added 3 commits February 15, 2023 19:08

Get support back on '1st' layer when raft is used.

a5a75fc

The 1st layer of the model is layer 0. This piece of code assumed layer 0 was part of the raft or the air-gap. Also consolidate if-statements. done as part of CURA-9860

casperlamboo reviewed Feb 22, 2023

View reviewed changes

src/raft.cpp Outdated Show resolved Hide resolved

Fix comment, function name, superfluous max.

f5ba433

Enact reviewer comments. done as part of CURA-9860

rburema marked this pull request as ready for review February 22, 2023 14:30

casperlamboo approved these changes Feb 22, 2023

View reviewed changes

casperlamboo merged commit 313f094 into 5.3 Feb 23, 2023

casperlamboo deleted the CURA-9860_fix_extra_support_layer_when_raft branch February 23, 2023 08:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CURA-9860] fix extra support layer when raft is enabled #1834

[CURA-9860] fix extra support layer when raft is enabled #1834

rburema commented Feb 15, 2023 •

edited

github-actions bot commented Feb 15, 2023 •

edited

casperlamboo left a comment •

edited

	/*!
	* \brief Get the height difference between the raft and the bottom of
	* layer 1.
	*
	* This is used for the filler layers because they don't use the
	* layer_0_z_overlap.
	*/
	static coord_t getZdiffBetweenRaftAndLayer1();

[CURA-9860] fix extra support layer when raft is enabled #1834

[CURA-9860] fix extra support layer when raft is enabled #1834

Conversation

rburema commented Feb 15, 2023 • edited

github-actions bot commented Feb 15, 2023 • edited

Unit Test Results

casperlamboo left a comment • edited

Choose a reason for hiding this comment

rburema commented Feb 15, 2023 •

edited

github-actions bot commented Feb 15, 2023 •

edited

casperlamboo left a comment •

edited