[CURA-9463] Speed up skin-edge support detection for detailed models. #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the considered areas to those that actually have infill to make 'infill skin edge support' from on the layer currently under consideration for the area determination. This can speed up the calculation for certain models a huge amount (under a minute of slicing versus half an hour kind of ballpark). Important, since we enabled skin edge support in the front-end by default instead of as an option. CURA-9463
casperlamboo
reviewed
Mar 1, 2023
casperlamboo
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit the considered areas to those that actually have infill to make 'infill skin edge support' from on the layer currently under consideration for the area determination.
This can speed up the calculation for certain models a huge amount (under a minute of slicing versus half an hour kind of ballpark).
Important, since we enabled skin edge support in the front-end by default instead of as an option.