Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wall line segments that have a flow < wall_min_flow are converted into travel moves. #721

Merged
merged 8 commits into from May 30, 2018
Merged

Wall line segments that have a flow < wall_min_flow are converted into travel moves. #721

merged 8 commits into from May 30, 2018

Commits on Mar 12, 2018

  1. Now wall line segments that have a flow < wall_min_flow are converted… 

    … into travel moves.
    @smartavionics
    smartavionics committed Mar 12, 2018
    Copy the full SHA
    9a0e0e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2018

  1. Omit final travel move if last wall line segment is too thin to print. 

    There's no point in moving to the end of the line because the next line may involve a
travel move at the beginning. If the next line does start at the end of the current line,
a move will be done anyway.
    @smartavionics
    smartavionics committed Apr 26, 2018
    Copy the full SHA
    f937e4c View commit details
    Browse the repository at this point in the history

  2. Don't move to the first point in line in case the first segment is to… 

    …o thin to print.

Instead, we delay moving until the first segment that is thick enough to print is to be
output.
    @smartavionics
    smartavionics committed Apr 26, 2018
    Copy the full SHA
    89b76c4 View commit details
    Browse the repository at this point in the history

  3. Don't initialise travel_required to true, only set it true when skipp… 

    …ing a thin segment.

Instead, when testing to see if a travel move is required we look at both travel_required
and first_line.
    @smartavionics
    smartavionics committed Apr 26, 2018
    Copy the full SHA
    72e8b93 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2018

  1. Use coord_t rather than int64_t.

    @smartavionics
    smartavionics committed May 25, 2018
    Copy the full SHA
    390c35f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2018

  1. Use getSettingAsRatio() rather than getSettingAsPercentage() / 100.

    @smartavionics
    smartavionics committed May 27, 2018
    Copy the full SHA
    fbcd451 View commit details
    Browse the repository at this point in the history

  2. Save time by using vSize2f() rather than vSize().

    @smartavionics
    smartavionics committed May 27, 2018
    Copy the full SHA
    e4828eb View commit details
    Browse the repository at this point in the history

Commits on May 29, 2018

  1. Remove the hack that avoids printing spurious short segments. 

    This was requested so that people can happily print walls with sub-50um lines.
    @smartavionics
    smartavionics committed May 29, 2018
    Copy the full SHA
    6b17c77 View commit details
    Browse the repository at this point in the history