Repaired Views dropdown in Preview stage #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(for plugins with 2 views or more)
nallath
approved these changes
Oct 28, 2021
nallath
requested changes
Oct 28, 2021
Co-authored-by: Jaime van Kessel <nallath@gmail.com>
Metadata can no longer be a list of dicts.
|
@nallath, your change request was great. Since we now get a metadata dict directly from each View object (instead of dicts/lists of dicts from every plugin) we no longer need to check for and process any list of dicts. |
|
Sorry it took me so long to re-review / test the changes! Somehow i missed the notification that you applied the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(for plugins with 2 views or more)
If a view has a _name, its ID is not PluginName but rather PluginName_ViewName. This is necessary to give unique IDs to each view in a plugin that has multiple views. However, it breaks this line:
because it tries to look for a plugin called PluginName_ViewName.
More info in Cura forums thread & issue #744.