Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimpleButton use of UM.ColorImage #874

Merged
merged 3 commits into from Jun 1, 2023

Conversation

fieldOfView
Copy link
Contributor

This PR fixes loading Cura on some systems where Qt does not like using ColorImage without a specific prefix of the UM package namespace.

Fixes Ultimaker/Cura#15524

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label May 20, 2023
Copy link
Member

@jellespijker jellespijker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

Thanks for fixing it so quickly @fieldOfView

@jellespijker jellespijker merged commit fd0d8ef into Ultimaker:main Jun 1, 2023
@fieldOfView fieldOfView deleted the fix_simplebutton branch June 1, 2023 08:06
@fieldOfView
Copy link
Contributor Author

It still puzzles me how the official builds did not fail on this. But oh well, it is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cura crashes on startup "Type UM.SimpleButton unavailable"
3 participants