Skip to content
This repository has been archived by the owner on Dec 9, 2022. It is now read-only.

WIP: setup.py: Windows: Trying to add Numpy and SciPy completely #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thopiekar
Copy link
Contributor

.. but without hooks.

@Ghostkeeper
Copy link
Contributor

So we'd remove the def load_numpy declarations and such as well.

And we're not using the MKL versions any more? Seems to me that this was added for a reason.

@LipuFei
Copy link
Contributor

LipuFei commented Dec 4, 2019

We are still using the MKL versions on Windows. I will create some builds with this change so we can test it.

@LipuFei
Copy link
Contributor

LipuFei commented Dec 6, 2019

Hi @thopiekar , this PR fails to build Cura on Windows. I got the following error messages:

[ 97%] Completed 'fdm_materials'
[ 97%] Built target fdm_materials
Scanning dependencies of target projects
[ 97%] Built target projects
Scanning dependencies of target build_bundle
running cx_Freeze
running build_exe
Traceback (most recent call last):
  File "setup.py", line 195, in <module>
    executables = executables
  File "X:\env\master\inst\lib\site-packages\cx_Freeze\dist.py", line 349, in setup
    distutils.core.setup(**attrs)
  File "X:\env\master\inst\lib\distutils\core.py", line 148, in setup
    dist.run_commands()
  File "X:\env\master\inst\lib\distutils\dist.py", line 955, in run_commands
    self.run_command(cmd)
  File "X:\env\master\inst\lib\distutils\dist.py", line 974, in run_command
    cmd_obj.run()
  File "X:\env\master\inst\lib\site-packages\cx_Freeze\dist.py", line 219, in run
    freezer.Freeze()
  File "X:\env\master\inst\lib\site-packages\cx_Freeze\freezer.py", line 621, in Freeze
    self.finder = self._GetModuleFinder()
  File "X:\env\master\inst\lib\site-packages\cx_Freeze\freezer.py", line 340, in _GetModuleFinder
    finder.IncludePackage(name)
  File "X:\env\master\inst\lib\site-packages\cx_Freeze\finder.py", line 653, in IncludePackage
    module = self._ImportModule(name, deferredImports)
  File "X:\env\master\inst\lib\site-packages\cx_Freeze\finder.py", line 350, in _ImportModule
    raise ImportError("No module named %r" % name)
ImportError: No module named 'scipy'
CMakeFiles\build_bundle.dir\build.make:56: recipe for target 'build_bundle' failed
mingw32-make[2]: *** [build_bundle] Error 1
CMakeFiles\Makefile2:598: recipe for target 'CMakeFiles/build_bundle.dir/all' failed
mingw32-make[1]: *** [CMakeFiles/build_bundle.dir/all] Error 2
Makefile:150: recipe for target 'all' failed
mingw32-make: *** [all] Error 2
[SSH] exit-status: 2

@Ghostkeeper
Copy link
Contributor

Well, it is marked as WIP after all :)

@thopiekar
Copy link
Contributor Author

Ok. I thought that the hooks were needed to create a minimal set of SciPy. Looks like they are needed to get SciPy packaged somehow.
Also, other people are having issues with it: https://bitbucket.org/anthony_tuininga/cx_freeze/issues/43/import-errors-when-using-cx_freeze-with

@LipuFei
Copy link
Contributor

LipuFei commented Jan 10, 2020

@thopiekar Are you still working on this?

@thopiekar
Copy link
Contributor Author

thopiekar commented Jan 11, 2020

Nope, and I feel a bit lost with it.
For me it seems that adding all the missing files needs to be done manually.

@LipuFei
Copy link
Contributor

LipuFei commented Jan 11, 2020

Well, apparently if you don't do that it won't work...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants