Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing [active]domains in clean.list #16

Closed
dnmTX opened this issue Jan 21, 2019 · 12 comments
Closed

missing [active]domains in clean.list #16

dnmTX opened this issue Jan 21, 2019 · 12 comments
Labels
bug Something isn't working

Comments

@dnmTX
Copy link

dnmTX commented Jan 21, 2019 •
edited

@funilrys here is a link(s) for reference(this is how i found out) but i remember i've notice that some domains were missing in the past but didn't think of it too much at the time. It's a kind of a concern.Let's hope that you'll be able to trace the issue:
anudeepND/blacklist#31 (comment)
anudeepND/blacklist#31 (comment)
anudeepND/blacklist#31 (comment)

P.S. Actually i found it in INACTIVE and that domain is very much alive so i'm thinking now that there is a bug with how the domains are considered active/inactive.
@dnmTX dnmTX added the bug Something isn't working label Jan 21, 2019
@dnmTX dnmTX changed the title missing domains in clean.list missing [active]domains in clean.list Jan 21, 2019
@funilrys
Copy link
Member

Hi @dnmTX please report to https://pyfunceble.readthedocs.io/en/latest/columns.html#doubleclick-net.

@dnmTX dnmTX mentioned this issue Jan 21, 2019
Closed
@dnmTX
Copy link
Author

dnmTX commented Jan 21, 2019

Reported ☝️

@funilrys
Copy link
Member

@dnmTX I meant: look at the documentation 😹

I had a good time with Mitch trying to optimize the process when we started (Around January 2017). We constated that all 404 domains for *.doubleclick.net where inactive so we put them as INACTIVE until the status code changes to something which is not 404 😸

We really do more than WHOIS and NSLOOKUP 😉

@dnmTX
Copy link
Author

dnmTX commented Jan 21, 2019

My bad(kind of embarrassed right now). I'll remove the issue. Still....
...don't you think that showing 404 on such a domains is kind of suspicious to say the least?
Probably it's a good idea to make some exception on those as they really need to remain blocked.

@funilrys
Copy link
Member

Closing as clarified.

Also: That beahavior can be disabled by maintainers at @dead-hosts. @mitchellkrogza decided that it's still good to keep it here.

@funilrys funilrys reopened this Feb 15, 2019
@funilrys
Copy link
Member

Something is coming (soon) around this @dnmTX 😸

@dnmTX
Copy link
Author

dnmTX commented Feb 15, 2019

I'll believe it when i see it 👀

@funilrys
Copy link
Member

Partial code is fast ready to ship will become complete code after next stable release of PyFunceble + modification of the administration file 😉

@funilrys
Copy link
Member

  • Correction: The code is ready as exeprimental and should not be considered as experimental anymore from the next release of PyFunceble.

funilrys added a commit to Ultimate-Hosts-Blacklist/repository-structure that referenced this issue Feb 15, 2019
@funilrys
fix (partially) Ultimate-Hosts-Blacklist/dev-center#16
9ff84f8 
Indeed, this patch introduce a way to quickly retest every special elements of PyFunceble in order to reintroduce domains which fill into Ultimate-Hosts-Blacklist/dev-center#16.

Note:
  * This fix the issue partially because the `no_special` configuration index of PyFunceble (cf: funilrys/PyFunceble#20) will only be available for us (Ultimate-Hosts-Blacklist) from the next stable release.
    * Indeed we (Ultimate-Hosts-Blacklist) only use the stable version of PyFunceble.
  * Code does not need to be updated on next stable release of PyFunceble because the `no_special` index is beforehand implemented.
  * Normally the current code should be suffisant but keep in mind that this is just experimental until the next release of PyFunceble (keep yourself updated).
  * The new file will be called `volatile.list`
Thanks to @dmtx for the effort. 😉
@funilrys
Copy link
Member

Oups wrong ping in commit 😭 I need to sleep 😂 catch you later @dnmTX.

Sorry for the noise @dmtx ...

@funilrys
Copy link
Member

Closing as it is now implemented.

@dnmTX
Copy link
Author

dnmTX commented Feb 24, 2019

🙌 ALL HAIL THE NEW VOLATILE.LIST 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@funilrys @dnmTX