Improved key state tracking #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the small keys below the bottom row. Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
We need to store the previous state of the keys, to figure out when a specific key is released, as opposed to simply not being pressed. This is required for layer keys such as `Mod` and `Fn` to work properly when there are more than one of them on the keymap. Without being able to tell when a key is released, we would not be able to turn a layer off only when no layer key is held. Not easily, anyway: we'd have to track the state of all layer keys... but then it is easier to just track them all. Thankfully, the memcpy at the end is fast, as it only needs to copy 70 bytes. Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
|
Thank you for the PR! Please see my comment in #15. |
|
Closing this PR, there's another coming that fixes #17, and includes this one too. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
prevLeftKeyStatesandprevRightKeyStatesarrays, which are used to store the previous state of the matrix. These are then used to determine when a key is released, as opposed to when it is just not pressed. Without these, if we had two or more layer keys, only the last one would work, because the rest would keep getting handled as releases (since we can't make a difference between release and noop, unless we know the previous state).We could just track layer keys, but there could be any number of them, so it is easier to just save the full matrix state. It's a memcpy of 70 bytes, fairly light.
(As an added bonus, the first commit adds the Mod & Space keys below the bottom row, as they appear on the default layout.)