Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to appdata file #682

Merged
merged 1 commit into from
May 2, 2023

Conversation

s09bQ5
Copy link
Collaborator

@s09bQ5 s09bQ5 commented May 1, 2023

This xml file contains information displayed in app stores like Flathub. If this additional information is not kept here, I have to patch the file for every release. This PR assumes the next release will be done today.

@barbeque-squared
Copy link
Collaborator

I assume this is also meant to go in before the release then? If yes, can you change the date to May 2 because the CI is going to take way too long for it to catch up and still do a release today.
(unless someone else wants to do the release)

I also assume that going forward, when doing a release we also have to add it to the list in this file?

@s09bQ5
Copy link
Collaborator Author

s09bQ5 commented May 1, 2023

I assume this is also meant to go in before the release then? If yes, can you change the date to May 2 because the CI is going to take way too long for it to catch up and still do a release today.

Done. The release build should be done after tagging v2023.5.0. Otherwise dists/linux/tasks.sh will add an entry similar to

<release version="2023.4.0-23-g5bacd71" type="development" date="2023-05-01T18:30:41+02:00" />

at the top of the list before baking that file into the AppImage.

I also assume that going forward, when doing a release we also have to add it to the list in this file?

Yes. It is possible to add more information about each release, but at minimum we need the version number of the release and its date.

@barbeque-squared
Copy link
Collaborator

I was planning to prepare everything locally (merging this, updating version numbers, tagging) and then just push the whole thing in one go tomorrow morning (because then I'll be around to babysit the CI and restart it by committing some witespace in case a job fails -- another something I should probably document as well).
That way, as far as CI/flathub is concerned, everything gets added at the same time and it should Just Work? I'll update the readme later this month to properly reflect this.

In the future I should probably create a ticket about a week or so in advance before a release, so people have a better chance to yell at me that something needs to go in, or that I'm forgetting something, or that the date doesn't work for who does the Mac builds, that kinda stuff.

@barbeque-squared barbeque-squared merged commit 6e4b5e1 into UltraStar-Deluxe:master May 2, 2023
@s09bQ5 s09bQ5 deleted the appdata branch May 2, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants