nicer fading

[barbeque-squared]

fixes #86
make fading from sing screen to score screen much nicer by unloading the video later

maybe it'll still show the background image for a fraction of a second if you disabled both the background + video by pressing V during a song. did not test visualizations.

demo video:

simplescreenrecorder-2023-08-30_10.40.34.mp4

for at least videos or background images it will just use whatever was on the last frame.

[basisbit]

Please make sure that this doesn't cause issues with the transition audio playback, when using a video file with audio integrated and using that audio as source.
If I remember correctly, OnHide gets called only after the transition is done and the next screen is already loaded, so there also is a chance that this here change introduces a memory leak when playing some plugins or the multiple-songs-in-a-row feature and maybe also for medley.

[barbeque-squared]

@basisbit I retested this with multiple webm's (audio+video from the same webm) as both individual songs as well as a medley, did not notice any issues.
I think the transitions within a medley were always hard. I can't really test this on Windows but anyone can download the PR build artifact and quickly verify that themselves. If it turns out there is a path somewhere that doesn't call onHide at all, I think that's more of a bug in that path and less in this item.

I don't know what you mean with the "multiple-songs-in-a-row feature"

[barbeque-squared]

Considering there's been no replies I'm merging this. If something substantially does break from this we can always just revert it (or fix it) and do a bugfix release.