Decrease the song number font size to avoid overlapping #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbeque-squared
approved these changes
Dec 23, 2023
There was a problem hiding this comment.
Very nice! The total count is one of those "you see it once, you know it" numbers, and what number the current song is, isn't that relevant imo. When searching the number of results is displayed in the search window anyway, so there's really no need for these numbers to be so massive.
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the song selection screen, the song number (for Roulette shown in the bottom right) in the format "xx/yy" may overlap with the year (for Roulette shown in the bottom middle) with large song collections.
This PR decreases the font size (and harmonizes them across different song menu styles) to avoid overlaps with the displayed year.