Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT Support? #303

Merged
merged 20 commits into from
Sep 25, 2020
Merged

AOT Support? #303

merged 20 commits into from
Sep 25, 2020

Conversation

HurricanKai
Copy link
Member

This PR includes the barebones support for AOT CoreRT and modifies the sample in Labs to function.

Changes include:

  • Window & InputWindowExtension changes to allow disabling of the default first party support. (This also means platforms are now lazy loaded)
  • 1 new Type with one function in each of SDL/GLFW input & windowing that adds the platform. (These are the only visible types in that namespace, not sure if desirable)
  • Adds .net 5 as build target to all projects, this means .net 5 will propagate through projects and dependencies, making it possible to enable features on .net 5 and higher only. This has been long overdue imo.

@Perksey
Copy link
Member

Perksey commented Sep 1, 2020

I wouldn't set projects to multi target unless it actually has .NET 5-specific enhancements. NuGet is smart enough to get a .NET 5 version of a package even if the referencing package only targets .NET Standard 2.0, but the dependency cross-targets.

@HurricanKai
Copy link
Member Author

Didn't know NuGet was that smart. I'd preferably keep all the multi-targeting to allow the possibility for the future. I plan on optimizing a lot of stuff with the awesome new features.
If you prefer, I'll remove the multi-targeting here, and re-add it once needed?

@Perksey
Copy link
Member

Perksey commented Sep 1, 2020

If you prefer, I'll remove the multi-targeting here, and re-add it once needed?

This sounds like the preferred way to go.

src/Input/Silk.NET.Input.Glfw/InputExtensions.cs Outdated Show resolved Hide resolved
src/Input/Silk.NET.Input.Glfw/InputExtensions.cs Outdated Show resolved Hide resolved
src/Input/Silk.NET.Input.Sdl/InputExtensions.cs Outdated Show resolved Hide resolved
src/Input/Silk.NET.Input.Sdl/InputExtensions.cs Outdated Show resolved Hide resolved
src/OpenCL/Silk.NET.OpenCL/Silk.NET.OpenCL.csproj Outdated Show resolved Hide resolved
src/Lab/CoreRTTest/Program.cs Outdated Show resolved Hide resolved
src/Lab/CoreRTTest/Program.cs Outdated Show resolved Hide resolved
src/Lab/CoreRTTest/Program.cs Outdated Show resolved Hide resolved
src/Lab/CoreRTTest/Program.cs Outdated Show resolved Hide resolved
src/Lab/CoreRTTest/Program.cs Show resolved Hide resolved
@HurricanKai HurricanKai mentioned this pull request Sep 3, 2020
@Perksey Perksey added this to To do in 2.0 Development Sep 6, 2020
@Perksey Perksey moved this from To do to In progress in 2.0 Development Sep 6, 2020
Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the unanswered comments from above, and...

src/Input/Silk.NET.Input.Sdl/SdlInput.cs Outdated Show resolved Hide resolved
src/Lab/CoreRTTest/Program.cs Outdated Show resolved Hide resolved
@HurricanKai HurricanKai force-pushed the 284-investigate-getting-silknet-to-work- branch from 2b61f74 to 13d2fad Compare September 25, 2020 09:16
@HurricanKai
Copy link
Member Author

Rebased onto origin/2.0 to get the RC1 changes. Git kinda died so I had to force push 😅

build/props/common.props Outdated Show resolved Hide resolved
@Perksey Perksey merged commit cde61b6 into 2.0 Sep 25, 2020
2.0 Development automation moved this from In progress to Done Sep 25, 2020
@HurricanKai HurricanKai deleted the 284-investigate-getting-silknet-to-work- branch September 25, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants