Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests coverage #21

Closed
bburda opened this issue Jun 26, 2020 · 2 comments · Fixed by #22 or #24
Closed

Fix tests coverage #21

bburda opened this issue Jun 26, 2020 · 2 comments · Fixed by #22 or #24
Labels
bug Something isn't working

Comments

@bburda
Copy link
Contributor

bburda commented Jun 26, 2020

It looks like the Travis CI is crashing silently, after #11
Travis Log
The -Wshadow with -Werror caused the test libs to crash.

The -Wshadow should be removed or exception for external dependencies should be added.
The Travis should return an error in such cases (when build or tests are failing).
@bburda bburda added the bug Something isn't working label Jun 26, 2020
@bburda
Copy link
Contributor Author

bburda commented Jun 29, 2020

This PR https://github.com/UmlautSoftwareDevelopmentAccount/AP-CoreTypes/pull/49 solves it partially.

@phongt phongt mentioned this issue Jun 30, 2020
Merged
@bburda bburda linked a pull request Jun 30, 2020 that will close this issue
travis.yml: add the build_ci script #22
Merged
@bburda
Copy link
Contributor Author

bburda commented Jul 3, 2020

Looks like, the codecov is still not working and requires further investigation.

@bburda bburda reopened this Jul 3, 2020
@bburda bburda linked a pull request Jul 3, 2020 that will close this issue
Added the run-clang-format.py call to the .travis.yml #24
Merged
@bburda bburda closed this as completed in #24 Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@bburda