Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to find hparam file for a custom model #96

Closed
me-manikanta opened this issue Nov 10, 2022 · 1 comment
Closed

Unable to find hparam file for a custom model #96

me-manikanta opened this issue Nov 10, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@me-manikanta
Copy link

🐛 Bug

When I am passing a custom model for generating the score, the command fails with the following error.

Exception: hparams.yaml file is missing!

I tried copying a hparams.yaml file to the same directory as the model but the score command fails with the same error.

I've then looked at the code to understand where it is checking for the path and tried to have a similar directory structure that is expected.

hparams_file = "/".join(checkpoint_path.split("/")[:-2] + ["hparams.yaml"])

This fixed the issue for me.

To Reproduce

Run comet-score command with a custom model, but no hparams file in the parent directory.

Expected behaviour

Generate the comet-score with custom models, with(or may be without specifying) hparams.yaml

Possible Solutions

  • [Not sure if possible] Pass default hparams if hparams.yaml file is not found
  • Update the docs to specify that there should be a hparams.yaml file in the parent directory of the custom model
  • Ability to specify hparams.yaml file as a param to command line
@me-manikanta me-manikanta added the bug Something isn't working label Nov 10, 2022
@ricardorei
Copy link
Collaborator

which version are you using? and what is the pytorch lightning version you have installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants