Run prettier (existing rules, no other changes) #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing per @jamesrp13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this repo hasn't been formatted in a long time.
This PR just runs prettier. This will stop unrelated formatting changes in future PRs when files are saved & linted.
No changes to existing rules.
Alternatively: we also could just delete the rules if they're not being used. That would allow us to have regular-looking JS (2 spaces per all JS style guides) and regular looking Rust (4 spaces per rustfmt) at the same time. Prettier can't format multiple languages differently inside a markdown file yet.
Let me know what you think.