Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow performance with Electron 10 #1062

Closed
UnchartedBull opened this issue Oct 9, 2020 · 5 comments · Fixed by #1438
Closed

Slow performance with Electron 10 #1062

UnchartedBull opened this issue Oct 9, 2020 · 5 comments · Fixed by #1438
Assignees
Labels
bug Something isn't working
Projects

Comments

@UnchartedBull
Copy link
Owner

UnchartedBull commented Oct 9, 2020

touchscreen seems to be noticeably slower after a157708.

  • Could be linked to *::before and *::after selectors.
  • Seems to be better while printing, which would support the pseudo-selector thesis, since there are less elements present while printing.
@UnchartedBull UnchartedBull added the bug Something isn't working label Oct 9, 2020
@UnchartedBull UnchartedBull self-assigned this Oct 9, 2020
@UnchartedBull UnchartedBull added this to To do in v3 Release via automation Oct 9, 2020
@UnchartedBull UnchartedBull moved this from To do to In progress in v3 Release Oct 11, 2020
@UnchartedBull
Copy link
Owner Author

traced back to Electron 10 upgrade. Current master runs fine with Electron 9. Needs further investigation.

@UnchartedBull UnchartedBull changed the title touchscreen response on dev is slow Slow performance with Electron 10 Oct 11, 2020
@UnchartedBull UnchartedBull moved this from In progress to To do in v3 Release Oct 11, 2020
@TheNeskik
Copy link

Could it be linked to Hardware Acceleration ?

I'll try this weekend to add
app.disableHardwareAcceleration();
to main.js

(Post this comment here as a remember for me)

@UnchartedBull
Copy link
Owner Author

Can be, I just tried another dev build the other day and enabled the Fake KMS OpenGL driver for the Raspberry (which in fact enables GPU accelerated CSS). The performance was still sup-bar and probably a little worse than Electron 9 with no Hardware Acceleration. Electron 9 with hardware accelerated CSS was butter-smooth, so I think there is something else going on. But I never tried to disableHardwareAcceleration from Electron directly because it does give a notable performance improvement with the CSS animations.

@UnchartedBull
Copy link
Owner Author

I found a few more things which could be the cause of this issue:

  • browserWindow.backgroundThrottling might be something to look into (set to false)
  • browserWindow.webgl Raspberry doesn't support WebGL out of the box, so disabling this might be worth a try as well
  • try building with a higher version of node, this probably won't have any effect whatsoever but it is worth a try. I'm currently building everything with 12.16.1, while Electron 10 uses 12.16.3. So trying to build everything with 15 might be something to try.

Those three points probably won't do much, but I wanted to write them down somewhere and they might be worth a try.

v3 Release automation moved this from To do to Done Mar 18, 2021
@Vamoss
Copy link

Vamoss commented Mar 1, 2023

Could it be linked to Hardware Acceleration ?

I'll try this weekend to add app.disableHardwareAcceleration(); to main.js

(Post this comment here as a remember for me)

This saved me hooooours of work trying to figure out why my application was so slow when running on touchscreen.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v3 Release
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants