Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nightly Builds of OctoDash #1009

Closed
o5 opened this issue Sep 24, 2020 · 25 comments
Closed

Add Nightly Builds of OctoDash #1009

o5 opened this issue Sep 24, 2020 · 25 comments
Labels
enhancement New feature or request

Comments

@o5
Copy link

o5 commented Sep 24, 2020

Is your feature request related to a problem? Please describe.
I would like to test current master version with #938

Describe the solution you'd like
http://gnethomelinux.com/OctoPi/nightly/

Additional context
I looked at CONTRIBUTING guide to build locally but without success on Mac with base environment (node, npm). Also Docker build would be cool if possible.

@o5 o5 added the enhancement New feature or request label Sep 24, 2020
@o5 o5 changed the title Add Nightly Builds of OctoDas Add Nightly Builds of OctoDash Sep 24, 2020
@TheNeskik
Copy link

I agree with you, it could be a good things to add.

I also tried to build locally. In Windows it is impossible since electron doesn't work on windows
On Ubuntu I managed to build the 3 deb file but after installing the package on my Pi3, it turned on a black screen after Ratpoison start. (It seems that my ubuntu is on amd64 and some dependencies are not compatible with armv7) but that's an other issue and I need to go deeper to understand everythings :)

@M1dn1ghtN1nj4
Copy link

@UnchartedBull is welcome to remove the link if he wants, but I have started a section on my website specifically for semi-nightly builds, as I am doing testing and customization as well. Let me know if they builds fail to work properly. Of course, there are some bugs, but as long as it doesn't fail to boot up or anything major, it should be good.

https://sites.google.com/view/m1dn1ght-3d/downloads/unofficial-octodash-builds

@TheNeskik
Copy link

Hi, nice work, On my fork, i managed to do some nightly build too.

For me, every build doesn't work after the commit 6458cc6
This commit use mdns and require to be re-build in order to work on raspberry. I didn't managed to do it, i will open a new issue for this

@UnchartedBull
Copy link
Owner

@M1dn1ghtN1nj4 thanks! Would you mind if I link that site in the README / wiki? Most recent build won't install until https://github.com/UnchartedBull/OctoDash/tree/fix/text-wrap has been merged as described in #1033 (comment).

@M1dn1ghtN1nj4
Copy link

Sure! I'm still trying to set up a one line command that will install my build like you have. I have limited time, but doing more on that tonight.

@M1dn1ghtN1nj4
Copy link

@UnchartedBull I created a new repo on my account, and will be posting the builds over there. I now have it linked to a modified install.sh script to make installing my builds easier. I still need to update my website to reflect that. So you'll be able to link to either my GIT page or my website. Or both if you prefer.

@M1dn1ghtN1nj4
Copy link

Ok, got the install script working properly now. Looks like everything is good. Currently the only issue I have is that after hitting SAVE in the settings menu, I get a blank screen, and the system is unresponsive. Other than that, it looks good.

@TheNeskik
Copy link

I'm having the same issue with the save button, I'm looking for this error.

I can say that if we look in ssh and try to run octodash, it returns 'Segmentation fault'. I'm wondering if this can be linked to the performance issue.

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 8, 2020 via email

@TheNeskik
Copy link

Yes, with some tests, I can say that octodash is slower when idle than when printing.
When i print, my screen is very responsive.
In my opinion, it became slow when Prettier plugin was added. But that's strange because i should not occure some performance issue.
When UnchartedBull made some change to prevent drag element, he changes the global css file with
*::After et *::before and maybe that is the cause of the issue. I read an article saying that those flag in css can slow the loading of the web page. Maybe that's what we are experiences with our Pi with less ressources than a normal computer ?
I'll look deeper this weekend for this issue

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 8, 2020 via email

@UnchartedBull
Copy link
Owner

I'll have a look at that as well once I have some spare time. Feel free to create a PR if you've found a fix :). Also the *::before and *::after aren't doing anything I think (they were mentioned in the article to prevent drag events, so I thought it can't hurt). Just remove them if you think that fixes the issue.

@UnchartedBull
Copy link
Owner

Closing this here for now, since the nightly builds are available thanks to @M1dn1ghtN1nj4. I'll update the ReadME soonish. The slow interface will be tracked in #1062. Thanks again!

@UnchartedBull
Copy link
Owner

Just a quick update: The issue was the upgrade to Electron 10, after I downgraded to 9 everything runs smoothly again. Still don't know why it is acting up on Electron 10, but that will be discussed in the other issue. Release 2.1 should be ready soon :)

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 11, 2020 via email

@UnchartedBull
Copy link
Owner

6d08f3c fresh and hot 👍

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 11, 2020 via email

@UnchartedBull
Copy link
Owner

The other PR is unrelated, master should be fine now.

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 12, 2020 via email

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 12, 2020 via email

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 12, 2020 via email

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 12, 2020 via email

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 12, 2020 via email

@M1dn1ghtN1nj4
Copy link

M1dn1ghtN1nj4 commented Oct 12, 2020 via email

@UnchartedBull
Copy link
Owner

just created - https://discord.gg/gTasZTz :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants