Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve standby mode #214

Closed
UnchartedBull opened this issue Oct 15, 2019 · 8 comments · Fixed by #378
Closed

Improve standby mode #214

UnchartedBull opened this issue Oct 15, 2019 · 8 comments · Fixed by #378
Assignees
Labels
enhancement New feature or request
Projects

Comments

@UnchartedBull
Copy link
Owner

Is your feature request related to a problem? Please describe.
Standby mode continues to call the API, which is unnecessary and can lead to a Race Condition that causes one 409 Error to show up. Need to kill Angular Singleton Service for that somehow (maybe reload?)

@UnchartedBull UnchartedBull added the enhancement New feature or request label Oct 15, 2019
@UnchartedBull UnchartedBull self-assigned this Oct 15, 2019
@UnchartedBull UnchartedBull added this to To do in Future via automation Oct 15, 2019
@spiff72
Copy link

spiff72 commented Oct 17, 2019

Following up on this one - if there was any way to represent the "Connect" button that is present in the web interface I think that would be very nice addition to the feature set. I have made some adjustments to the custom commands to suit my printer (Home doesn't do a bed level check, different temps for the preheat, etc.), but I would love to see a button that would let me connect to the printer after a reboot.

@UnchartedBull
Copy link
Owner Author

That actually is included in the current revision of the standby mode. If OctoDash detects that the Printer is not connected it will go into sleep mode. Once you press the screen it sends a connect command to OctoPrint and will reenable itself. There is just no separate button ...

@spiff72
Copy link

spiff72 commented Oct 17, 2019

Ok good to know. I will check this out further. I (re)installed this after getting a new screen to use with it. I set it up on Tuesday so if things changed since then I am not up to date.

@UnchartedBull
Copy link
Owner Author

It isn't released yet (just for my dev build). You can have a sneak peak at new features in the screenshots folder mostly though: https://github.com/UnchartedBull/OctoDash/blob/master/screenshots/sleeping.png ;). Will be included in the next release.

@spiff72
Copy link

spiff72 commented Oct 19, 2019

That actually is included in the current revision of the standby mode. If OctoDash detects that the Printer is not connected it will go into sleep mode. Once you press the screen it sends a connect command to OctoPrint and will reenable itself. There is just no separate button ...

Out of curiosity - is there something going on behind the scenes that makes this able to connect to the printer in a case where the raspberry pi has just been rebooted? I have NEVER seen this happen with my installation and printer (Prusa i3 MK3S). I have the "automatically connect at server startup" item ticked in the connection section of Octoprint, but it never connects after a reboot - I always have to click the connect button to get the printer connected.

@UnchartedBull
Copy link
Owner Author

It will show that message everytime OctoPrint is disconnected, so after a reboot as well if the autoconnect isn't working. Just tap the screen and it will connect to the Printer :)

@spiff72
Copy link

spiff72 commented Oct 19, 2019

I discovered that I needed to specify the actual port (not AUTO), save that setting, and now it does AUTO connect after a reboot.

@UnchartedBull
Copy link
Owner Author

Great that you sorted that out! Going to leave this issue open, because there still is some stuff to do regarding standby :)

@UnchartedBull UnchartedBull removed this from To do in Future Jan 22, 2020
@UnchartedBull UnchartedBull added this to To do in v2 Release via automation Jan 22, 2020
@UnchartedBull UnchartedBull moved this from To do to In progress in v2 Release Jan 22, 2020
v2 Release automation moved this from In progress to Done Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
v2 Release
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants