Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current layer display offset config #480

Closed
evilbobbins opened this issue Mar 9, 2020 · 2 comments · Fixed by #511
Closed

Current layer display offset config #480

evilbobbins opened this issue Mar 9, 2020 · 2 comments · Fixed by #511
Assignees
@UnchartedBull
Labels
enhancement New feature or request

Comments

@evilbobbins
Copy link

Adding of a layer offset option I.E. on my printer octoprint starts on layer 0 on the octoprint display but layer 1 on Octodash.
Fixing this with an off set in Octoprint offsets Octodash to start on layer 2

Could a layer offset option be added so keep them in sync when this is the case?
@evilbobbins evilbobbins added the enhancement New feature or request label Mar 9, 2020
@UnchartedBull
Copy link
Owner

OctoDash currently always adds 1 to the layer count - I didn't know that DisplayLayerProgress supports an offset. The OctoDash offset will be removed in the next version, so everything is in sync. Thanks for the info!

@UnchartedBull UnchartedBull self-assigned this Mar 9, 2020
@evilbobbins
Copy link
Author

That's great thanks for the speedy reply :) amazing work btw :)

@UnchartedBull UnchartedBull mentioned this issue Mar 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@UnchartedBull UnchartedBull

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use hardcoded layer offset UnchartedBull/OctoDash
2 participants
@UnchartedBull @evilbobbins