Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail issue in print screen after V2.0 update #873

Closed
mmoraes80 opened this issue Aug 1, 2020 · 11 comments · Fixed by #938
Closed

Thumbnail issue in print screen after V2.0 update #873

mmoraes80 opened this issue Aug 1, 2020 · 11 comments · Fixed by #938
Assignees
Labels
bug Something isn't working
Projects

Comments

@mmoraes80
Copy link

mmoraes80 commented Aug 1, 2020

Describe the bug
When I start a print job sliced with Prusa Slicer, a tiny thumbnail is shown inside the progress circle (not even in the center of the circle). Is Octodash supposed to show the thumbnail, the circle, or both?

I also don't see the little yellow thermometer on the top right corner nor the little printer icons as in the attached picture.

To Reproduce
Steps to reproduce the behavior:

  1. Slice a model within Prusa Slicer
  2. Send to Octoprint and start printing
  3. Octodash main printing screen
  4. See error

Expected behavior
In the Octodash GitHub main page, there is a picture of the main printing screen with the thumbnail without the progress circle. Has it changed in the new update?

Screenshots
If applicable, add screenshots to help explain your problem.
image

@mmoraes80 mmoraes80 added the bug Something isn't working label Aug 1, 2020
@thegarbz
Copy link
Collaborator

thegarbz commented Aug 1, 2020

The picture on the main page is ancient and predates the progress meter. Ever since support for Prusaslicer was added the preview was always inside the progress circle.

Also the picture is largest if the dimensions are square. I suggest configuring prusaslicer to make 256x256 thumbnails.

@mmoraes80
Copy link
Author

The picture on the main page is ancient and predates the progress meter. Ever since support for Prusaslicer was added the preview was always inside the progress circle.

Also the picture is largest if the dimensions are square. I suggest configuring prusaslicer to make 256x256 thumbnails.

Thank you for the feedback. I was able to increase the size of the Thumbnail to 256x256 (and 512x512 as a test) but the image is still not centered inside the progress circle gauge.

@thegarbz
Copy link
Collaborator

thegarbz commented Aug 1, 2020

Can't help much beyond suggesting that you very very carefully check your UI and compare it with other examples. I had an issue where UI elements didn't line up correctly which I narrowed down to my display being at the wrong resolution. It stretched to the correct resolution but reported the wrong resolution causing the interface to be offset. I had that on my 3.5" LCD. No further issues with a larger LCD.

For comparison here's a screenshot with 256x256 thumbnails running the v2.0 update:
https://imgur.com/a/pd3LYfF

@mmoraes80
Copy link
Author

Can't help much beyond suggesting that you very very carefully check your UI and compare it with other examples. I had an issue where UI elements didn't line up correctly which I narrowed down to my display being at the wrong resolution. It stretched to the correct resolution but reported the wrong resolution causing the interface to be offset. I had that on my 3.5" LCD. No further issues with a larger LCD.

For comparison here's a screenshot with 256x256 thumbnails running the v2.0 update:
https://imgur.com/a/pd3LYfF

Thanks for the feedback! What would be the correct resolution in this case? I am using an UCTronics 3.5 LCD screen. One thing I noticed is that my thumbnail doesn't; show the background though.

@thegarbz
Copy link
Collaborator

thegarbz commented Aug 2, 2020

I'd love to know how to disable the background, but that's likely a slicer setting.

Correct resolution is 480x320 according to a quick google search. Worth checking in the raspberry pi setup in /boot/config.txt if that is set correctly.

@jneilliii
Copy link
Contributor

Looking at the difference between the two screenshots it looks like one of you is using UltimakerFormatPackage plugin and one is using PrusaSlicerThumbnails. UFP always output the same 300x300 square thumbnail size, whereas PrusaSlicer will export the image based on the size configured in the printer's ini file.

@jneilliii
Copy link
Contributor

I'm curious, does the discard button close the thumbnail view and show the print progress?

@UnchartedBull
Copy link
Owner

That image you posted is still valid. You can open this screen by loading a file (clicking the blue arrow up button in the file details view). During Print the image will be within the progress ring and smaller. You can also switch back to percentage by just tapping the image once. There are currently some discussion on how to make the image bigger without everything being cluttered.

If your image isn't centered with a square aspect ratio please post a screenshot/photo here.

@mmoraes80
Copy link
Author

mmoraes80 commented Aug 3, 2020

I managed to have the screen showing up but I don't the image size that big (proportional to the other items of the screen). Also, during printing, the little thumbnail is aligned to the top (even at 300x300) not centered in the middle of the progress gauge. Ah! and I get no background in my thumbnails... I am using Super Slicer and I think the background is only generated when you are using a Prusa machine, because you do have the bed rendering which doens;t happen in custom printer profiles.

@ruralaccent
Copy link

ruralaccent commented Aug 5, 2020

I get the small. The thumbnail from Prusa Slicer is tiny and off centre within the progress 'ring' in Octodash.

@UnchartedBull
Copy link
Owner

I'll have a look at this later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
v3 Release
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants