Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/tasmota #1581

Merged
merged 16 commits into from Mar 29, 2021
Merged

feature/tasmota #1581

merged 16 commits into from Mar 29, 2021

Conversation

jneilliii
Copy link
Contributor

@jneilliii jneilliii commented Mar 20, 2021 •
edited

  • add Tasmota plugin power options
  • add TasmotaMQTT plugin power options

@jneilliii
feature/tasmota (#6)
bf23ee1 
* add tasmota plugin power options
@jneilliii jneilliii mentioned this pull request Mar 20, 2021
Closed
@jneilliii
Copy link
Contributor Author

@UnchartedBull I'm not sure the best way to handle the initial setup wizard for the config, but during my testing the last Tasmota MQTT option for installed plugins appears to be out of view and it wasn't automatically scrollable (at least in windows dev testing).

@UnchartedBull
Copy link
Owner

I'll have a look at this after v3 beta is released, should be included in the final v3 release! :)

UnchartedBull
UnchartedBull requested changes Mar 29, 2021
View reviewed changes
Copy link
Owner

@UnchartedBull UnchartedBull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid PR. Thank you! Would be great if you could replace idx and relayN with more descriptive variable names (plus the functions in the configService). If that is done this is ready to be merged. I'll fix the initial setup before the final release then.

src/app/app.service.ts Outdated Show resolved Hide resolved
src/app/config/config.model.ts Outdated Show resolved Hide resolved
src/app/config/config.model.ts Outdated Show resolved Hide resolved
@jneilliii
Copy link
Contributor Author

requested changes completed

@UnchartedBull UnchartedBull merged commit aeb4249 into UnchartedBull:main Mar 29, 2021
@UnchartedBull
Copy link
Owner

Thanks!

pciavald pushed a commit to pciavald/OctoDash that referenced this pull request May 12, 2021
@jneilliii @dependabot-preview
@JcMinarro @UnchartedBull @pciavald
feature/tasmota (UnchartedBull#1581)
9adfe9d 
* feature/tasmota (UnchartedBull#6)

* add tasmota plugin power options

* add Tasmota MQTT plugin support

* update install script for power plugins

* Bump lottie-web from 5.7.6 to 5.7.7 (UnchartedBull#1587)

* Update scripts urls in docs files (UnchartedBull#1585)

* Bump @typescript-eslint/parser from 4.18.0 to 4.19.0 (UnchartedBull#1589)

* Bump @typescript-eslint/eslint-plugin from 4.18.0 to 4.19.0 (UnchartedBull#1590)

* Fix a few small bugs (UnchartedBull#1588)

* fix websocket and config upgrade bug (UnchartedBull#1594)

* cache animations (UnchartedBull#1595)

* fix formatting

* update idx to index and relayN to relayNumber

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Jc Miñarro <josecarlos.minarro@gmail.com>
Co-authored-by: Timon G <timon.gaebelein@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnchartedBull UnchartedBull UnchartedBull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jneilliii @UnchartedBull @JcMinarro